From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH RFC net-next 0/3] net: phy: sfp: Warn when using generic PHY driver Date: Wed, 7 Nov 2018 01:59:41 +0100 Message-ID: <20181107005941.GB30774@lunn.ch> References: <20181106232913.17216-1-f.fainelli@gmail.com> <20181106.153844.1612363235041286689.davem@davemloft.net> <20181107000322.GP30658@n2100.armlinux.org.uk> <20181107003448.GQ30658@n2100.armlinux.org.uk> <38f03d3d-d25d-6ff3-2f44-baa01e060746@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Russell King - ARM Linux , David Miller , netdev@vger.kernel.org To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:52806 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388174AbeKGK1q (ORCPT ); Wed, 7 Nov 2018 05:27:46 -0500 Content-Disposition: inline In-Reply-To: <38f03d3d-d25d-6ff3-2f44-baa01e060746@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: > Another approach could be to maintain a list of modules that do not work > with the generic PHY driver and therefore require a specialized driver, > in that case we could even go as far as not letting sfp_sm_probe_phy() > return success. Not sure how well things would scale, probably not too > bad given there are only a handful of users of the SFP framework thus far... Hi Florian Blacklisting modules with known issues with the generic driver does not sound too bad. This is just a warning, a helpful hint, and it is not going to work anyway. And i don't see scaling problems, Copper SFPs seems quite odd to start with... Andrew