From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH bpf-next 3/3] bpftool: support loading flow dissector
Date: Wed, 7 Nov 2018 15:29:17 -0800
Message-ID: <20181107152917.729ea83c@cakuba.netronome.com>
References: <20181107224356.73080-1-sdf@google.com>
        <20181107224356.73080-4-sdf@google.com>
        <20181107150944.5d5480ba@cakuba.netronome.com>
        <20181107231333.n34ffy4dl6rtbs7e@mini-arch>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Stanislav Fomichev <sdf@google.com>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, ast@kernel.org,
        daniel@iogearbox.net, shuah@kernel.org,
        quentin.monnet@netronome.com, guro@fb.com,
        jiong.wang@netronome.com, bhole_prashant_q7@lab.ntt.co.jp,
        john.fastabend@gmail.com, jbenc@redhat.com,
        treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com,
        sandipan@linux.vnet.ibm.com
To: Stanislav Fomichev <sdf@fomichev.me>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl1-f193.google.com ([209.85.214.193]:39157 "EHLO
        mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726982AbeKHJCC (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 8 Nov 2018 04:02:02 -0500
Received: by mail-pl1-f193.google.com with SMTP id b5-v6so8580387pla.6
        for <netdev@vger.kernel.org>; Wed, 07 Nov 2018 15:29:21 -0800 (PST)
In-Reply-To: <20181107231333.n34ffy4dl6rtbs7e@mini-arch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote:
> On 11/07, Jakub Kicinski wrote:
> > On Wed,  7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote:  
> > > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \
> > >         key 0 0 0 0 \
> > >         value pinned /sys/fs/bpf/flow/IP/0  
> > 
> > Where is that /0 coming from ?  Is that in source code?  I don't see
> > libbpf adding it, maybe I'm missing something.  
> libbpf adds that, that's a program instance:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/lib/bpf/libbpf.c#n1744

Ugh, I was looking at bpf_object__pin() which uses names :(

We never use this multi-instance thing, and I don't think bpftool ever
will, so IMHO it'd be good if we just re-did the pinning loop in
bpftool.