From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net-next 04/11] selftests: pmtu: Introduce tests for IPv4/IPv6 over VxLAN over IPv6 Date: Wed, 7 Nov 2018 20:54:29 +0100 Message-ID: <20181107205429.5cf8a584@redhat.com> References: <366b75ae560cc2d0b3a0f69b84d43b621c8fcce4.1541533786.git.sbrivio@redhat.com> <3f6578a6-623b-a5cc-68fd-29b25a4585e8@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Sabrina Dubroca , Xin Long , netdev@vger.kernel.org To: David Ahern Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46246 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbeKHF01 (ORCPT ); Thu, 8 Nov 2018 00:26:27 -0500 In-Reply-To: <3f6578a6-623b-a5cc-68fd-29b25a4585e8@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 7 Nov 2018 12:28:21 -0700 David Ahern wrote: > On 11/6/18 2:39 PM, Stefano Brivio wrote: > > Use a router between endpoints, implemented via namespaces, set a low MTU > > between router and destination endpoint, exceed it and check PMTU value in > > route exceptions. > > > > Reviewed-by: Sabrina Dubroca > > Signed-off-by: Stefano Brivio > > --- > > This only introduces tests over VxLAN over IPv6 right now. I'll introduce > > tests over IPv4 (they can be added trivially) once DF configuration support > > is accepted into iproute2. > > you can add them now and wrapped in a 'does ip support the df option' > check. That is needed regardless of order (kernel vs iproute2). True, I thought about that, but then I also thought that if we end up with a different syntax for the iproute2 command, that becomes ugly. Then yes, the check would be there -- it's actually already there, that || return 1 after the ip-link command. -- Stefano