From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2 net-next 1/2] iplink_vxlan: Add DF configuration
Date: Wed, 7 Nov 2018 21:30:24 +0100 [thread overview]
Message-ID: <20181107213024.1645d71e@redhat.com> (raw)
In-Reply-To: <01b41b92-1cba-a81f-523c-99c00750538a@gmail.com>
On Wed, 7 Nov 2018 13:03:34 -0700
David Ahern <dsahern@gmail.com> wrote:
> On 11/6/18 2:39 PM, Stefano Brivio wrote:
> > diff --git a/ip/iplink_vxlan.c b/ip/iplink_vxlan.c
> > index 7fc0e2b4eb06..86afbe1334f0 100644
> > --- a/ip/iplink_vxlan.c
> > +++ b/ip/iplink_vxlan.c
> > @@ -31,6 +31,7 @@ static void print_explain(FILE *f)
> > " [ local ADDR ]\n"
> > " [ ttl TTL ]\n"
> > " [ tos TOS ]\n"
> > + " [ df DF ]\n"
> > " [ flowlabel LABEL ]\n"
> > " [ dev PHYS_DEV ]\n"
> > " [ dstport PORT ]\n"
>
> Since it is the df bit, that user option seems fine to me. Should be ok
> to use that for your probe on iproute2 support.
Okay, then I'll use it in v2 of the kernel series.
> That said, the man-page update should spell out what df refers to.
Sure, I'll add that.
--
Stefano
next prev parent reply other threads:[~2018-11-08 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 21:39 [PATCH iproute2 net-next 0/2] Add DF configuration for VxLAN and GENEVE link types Stefano Brivio
2018-11-06 21:39 ` [PATCH iproute2 net-next 1/2] iplink_vxlan: Add DF configuration Stefano Brivio
2018-11-07 20:03 ` David Ahern
2018-11-07 20:30 ` Stefano Brivio [this message]
2018-11-06 21:39 ` [PATCH iproute2 net-next 2/2] iplink_geneve: " Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181107213024.1645d71e@redhat.com \
--to=sbrivio@redhat.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).