netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Shannon Nelson <shannon.nelson@oracle.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 03/12] ixgbe: allow IPsec Tx offload in VEPA mode
Date: Wed,  7 Nov 2018 14:48:21 -0800	[thread overview]
Message-ID: <20181107224830.9737-4-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <20181107224830.9737-1-jeffrey.t.kirsher@intel.com>

From: Shannon Nelson <shannon.nelson@oracle.com>

When it's possible that the PF might end up trying to send a
packet to one of its own VFs, we have to forbid IPsec offload
because the device drops the packets into a black hole.
See commit 47b6f50077e6 ("ixgbe: disallow IPsec Tx offload
when in SR-IOV mode") for more info.

This really is only necessary when the device is in the default
VEB mode.  If instead the device is running in VEPA mode,
the packets will go through the encryption engine and out the
MAC/PHY as normal, and get "hairpinned" as needed by the switch.

So let's not block IPsec offload when in VEPA mode.  To get
there with the ixgbe device, use the handy 'bridge' command:
	bridge link set dev eth1 hwmode vepa

Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
index fd1b0546fd67..4d77f42e035c 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
@@ -4,6 +4,7 @@
 #include "ixgbe.h"
 #include <net/xfrm.h>
 #include <crypto/aead.h>
+#include <linux/if_bridge.h>
 
 #define IXGBE_IPSEC_KEY_BITS  160
 static const char aes_gcm_name[] = "rfc4106(gcm(aes))";
@@ -693,7 +694,8 @@ static int ixgbe_ipsec_add_sa(struct xfrm_state *xs)
 	} else {
 		struct tx_sa tsa;
 
-		if (adapter->num_vfs)
+		if (adapter->num_vfs &&
+		    adapter->bridge_mode != BRIDGE_MODE_VEPA)
 			return -EOPNOTSUPP;
 
 		/* find the first unused index */
-- 
2.19.1

  parent reply	other threads:[~2018-11-08  8:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 22:48 [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-11-07 Jeff Kirsher
2018-11-07 22:48 ` [net-next 01/12] igbvf: Replace spin_is_locked() with lockdep Jeff Kirsher
2018-11-07 22:48 ` [net-next 02/12] ixgbe: don't clear_bit on xdp_ring->state if xdp_ring is null Jeff Kirsher
2018-11-07 22:48 ` Jeff Kirsher [this message]
2018-11-07 22:48 ` [net-next 04/12] ixgbevf: add support for software timestamps Jeff Kirsher
2018-11-07 22:48 ` [net-next 05/12] intel-ethernet: software timestamp skbs as late as possible Jeff Kirsher
2018-11-07 22:48 ` [net-next 06/12] i40e/ixgbe/igb: fail on new WoL flag setting WAKE_MAGICSECURE Jeff Kirsher
2018-11-08  6:05   ` Kevin Easton
2018-11-08  6:42     ` Michal Kubecek
2018-11-08 21:53       ` Jeff Kirsher
2018-11-07 22:48 ` [net-next 07/12] igc: Remove set but not used variables 'ctrl_ext, link_mode' Jeff Kirsher
2018-11-07 22:48 ` [net-next 08/12] igc: Remove set but not used variable 'pci_using_dac' Jeff Kirsher
2018-11-07 22:48 ` [net-next 09/12] igc: fix error return handling from call to netif_set_real_num_tx_queues Jeff Kirsher
2018-11-07 22:48 ` [net-next 10/12] igc: Tidy up some white space Jeff Kirsher
2018-11-07 22:48 ` [net-next 11/12] e1000e: allow non-monotonic SYSTIM readings Jeff Kirsher
2018-11-07 22:48 ` [net-next 12/12] igc: Clean up code Jeff Kirsher
2018-11-08 11:00   ` Joe Perches
2018-11-08 12:09     ` Neftin, Sasha
2018-11-08  7:07 ` [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-11-07 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181107224830.9737-4-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    --cc=shannon.nelson@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).