From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [net-next PATCH v2] net: sched: cls_flower: Classify packets using port ranges Date: Thu, 08 Nov 2018 15:15:40 -0800 (PST) Message-ID: <20181108.151540.1050553509106510974.davem@davemloft.net> References: <154162576240.57813.14471543870620442657.stgit@anamhost.jf.intel.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, sridhar.samudrala@intel.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: amritha.nambiar@intel.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:38896 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726599AbeKIIxb (ORCPT ); Fri, 9 Nov 2018 03:53:31 -0500 In-Reply-To: <154162576240.57813.14471543870620442657.stgit@anamhost.jf.intel.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Amritha Nambiar Date: Wed, 07 Nov 2018 13:22:42 -0800 > diff --git a/include/uapi/linux/pkt_cls.h b/include/uapi/linux/pkt_cls.h > index 401d0c1..b63c3cf 100644 > --- a/include/uapi/linux/pkt_cls.h > +++ b/include/uapi/linux/pkt_cls.h > @@ -405,6 +405,11 @@ enum { > TCA_FLOWER_KEY_UDP_SRC, /* be16 */ > TCA_FLOWER_KEY_UDP_DST, /* be16 */ > > + TCA_FLOWER_KEY_PORT_SRC_MIN, /* be16 */ > + TCA_FLOWER_KEY_PORT_SRC_MAX, /* be16 */ > + TCA_FLOWER_KEY_PORT_DST_MIN, /* be16 */ > + TCA_FLOWER_KEY_PORT_DST_MAX, /* be16 */ > + > TCA_FLOWER_FLAGS, > TCA_FLOWER_KEY_VLAN_ID, /* be16 */ > TCA_FLOWER_KEY_VLAN_PRIO, /* u8 */ > @@ -518,6 +523,8 @@ enum { I don't think you can do this without breaking UAPI, this changes the value of TCA_FLOWER_FLAGS and all subsequent values in this enumeration.