From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
jiri@resnulli.us, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
nogah.frankel@gmail.com, yuvalm@mellanox.com
Subject: Re: [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads
Date: Thu, 08 Nov 2018 16:20:06 -0800 (PST) [thread overview]
Message-ID: <20181108.162006.1694208064641283923.davem@davemloft.net> (raw)
In-Reply-To: <20181108013340.20983-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Wed, 7 Nov 2018 17:33:33 -0800
> This series refactors the "switchdev" Qdisc offloads a little. We have
> a few Qdiscs which can be fully offloaded today to the forwarding plane
> of switching devices.
>
> First patch adds a helper for handing statistic dumps, the code seems
> to be copy pasted between PRIO and RED. Second patch removes unnecessary
> parameter from RED offload function. Third patch makes the MQ offload
> use the dump helper which helps it behave much like PRIO and RED when
> it comes to the TCQ_F_OFFLOADED flag. Patch 4 adds a graft helper,
> similar to the dump helper.
>
> Patch 5 is unrelated to offloads, qdisc_graft() code seemed ripe for a
> small refactor - no functional changes there.
>
> Last two patches move the qdisc_put() call outside of the sch_tree_lock
> section for RED and PRIO. The child Qdiscs will get removed from the
> hierarchy under the lock, but having the put (and potentially destroy)
> called outside of the lock helps offload which may choose to sleep,
> and it should generally lower the Qdisc change impact.
Series applied, thanks Jakub.
prev parent reply other threads:[~2018-11-09 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 1:33 [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 1/7] net: sched: add an offload dump helper Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 2/7] net: sched: red: remove unnecessary red_dump_offload_stats parameter Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 3/7] net: sched: set TCQ_F_OFFLOADED flag for MQ Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 4/7] net: sched: add an offload graft helper Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 5/7] net: sched: refactor grafting Qdiscs with a parent Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 6/7] net: sched: red: delay destroying child qdisc on replace Jakub Kicinski
2018-11-08 1:33 ` [PATCH net-next 7/7] net: sched: prio: delay destroying child qdiscs on change Jakub Kicinski
2018-11-08 11:48 ` [PATCH net-next 0/7] net: sched: prepare for more Qdisc offloads Toke Høiland-Jørgensen
2018-11-08 16:02 ` Jakub Kicinski
2018-11-08 21:20 ` Toke Høiland-Jørgensen
2018-11-09 0:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108.162006.1694208064641283923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nogah.frankel@gmail.com \
--cc=oss-drivers@netronome.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).