From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: bcmgenet: return correct value 'ret' from bcmgenet_power_down Date: Thu, 08 Nov 2018 16:22:01 -0800 (PST) Message-ID: <20181108.162201.360454923619072769.davem@davemloft.net> References: <1541642923-81463-1-git-send-email-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: opendmb@gmail.com, f.fainelli@gmail.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: yuehaibing@huawei.com Return-path: In-Reply-To: <1541642923-81463-1-git-send-email-yuehaibing@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: YueHaibing Date: Thu, 8 Nov 2018 02:08:43 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function 'bcmgenet_power_down': > drivers/net/ethernet/broadcom/genet/bcmgenet.c:1136:6: warning: > variable 'ret' set but not used [-Wunused-but-set-variable] > > bcmgenet_power_down should return 'ret' instead of 0. > > Fixes: ca8cf341903f ("net: bcmgenet: propagate errors from bcmgenet_power_down") > Signed-off-by: YueHaibing Applied, thanks.