* [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers
@ 2018-11-08 17:44 Michał Mirosław
2018-11-08 17:44 ` [PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT Michał Mirosław
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Michał Mirosław @ 2018-11-08 17:44 UTC (permalink / raw)
To: netdev
Cc: Claudiu Manoil, Faisal Latif, Pravin B Shelar, Shiraz Saleem, dev,
linux-rdma
This series removes VLAN_TAG_PRESENT use from network drivers in
preparation to removing its special meaning.
Michał Mirosław (4):
i40iw: remove use of VLAN_TAG_PRESENT
cnic: remove use of VLAN_TAG_PRESENT
gianfar: remove use of VLAN_TAG_PRESENT
OVS: remove use of VLAN_TAG_PRESENT
drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 +++----
drivers/net/ethernet/broadcom/cnic.c | 2 +-
.../net/ethernet/freescale/gianfar_ethtool.c | 8 +++----
net/openvswitch/actions.c | 13 +++++++----
net/openvswitch/flow.c | 4 ++--
net/openvswitch/flow.h | 2 +-
net/openvswitch/flow_netlink.c | 22 +++++++++----------
7 files changed, 31 insertions(+), 28 deletions(-)
--
2.19.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT 2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław @ 2018-11-08 17:44 ` Michał Mirosław 2018-11-08 17:44 ` [PATCH net-next 3/4] gianfar: " Michał Mirosław ` (5 subsequent siblings) 6 siblings, 0 replies; 9+ messages in thread From: Michał Mirosław @ 2018-11-08 17:44 UTC (permalink / raw) To: netdev Cc: Faisal Latif, Shiraz Saleem, Claudiu Manoil, Pravin B Shelar, dev, linux-rdma Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/i40iw/i40iw_cm.c b/drivers/infiniband/hw/i40iw/i40iw_cm.c index 771eb6bd0785..4b3999d88c9e 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_cm.c +++ b/drivers/infiniband/hw/i40iw/i40iw_cm.c @@ -404,7 +404,7 @@ static struct i40iw_puda_buf *i40iw_form_cm_frame(struct i40iw_cm_node *cm_node, if (pdata) pd_len = pdata->size; - if (cm_node->vlan_id < VLAN_TAG_PRESENT) + if (cm_node->vlan_id <= VLAN_VID_MASK) eth_hlen += 4; if (cm_node->ipv4) @@ -433,7 +433,7 @@ static struct i40iw_puda_buf *i40iw_form_cm_frame(struct i40iw_cm_node *cm_node, ether_addr_copy(ethh->h_dest, cm_node->rem_mac); ether_addr_copy(ethh->h_source, cm_node->loc_mac); - if (cm_node->vlan_id < VLAN_TAG_PRESENT) { + if (cm_node->vlan_id <= VLAN_VID_MASK) { ((struct vlan_ethhdr *)ethh)->h_vlan_proto = htons(ETH_P_8021Q); vtag = (cm_node->user_pri << VLAN_PRIO_SHIFT) | cm_node->vlan_id; ((struct vlan_ethhdr *)ethh)->h_vlan_TCI = htons(vtag); @@ -463,7 +463,7 @@ static struct i40iw_puda_buf *i40iw_form_cm_frame(struct i40iw_cm_node *cm_node, ether_addr_copy(ethh->h_dest, cm_node->rem_mac); ether_addr_copy(ethh->h_source, cm_node->loc_mac); - if (cm_node->vlan_id < VLAN_TAG_PRESENT) { + if (cm_node->vlan_id <= VLAN_VID_MASK) { ((struct vlan_ethhdr *)ethh)->h_vlan_proto = htons(ETH_P_8021Q); vtag = (cm_node->user_pri << VLAN_PRIO_SHIFT) | cm_node->vlan_id; ((struct vlan_ethhdr *)ethh)->h_vlan_TCI = htons(vtag); @@ -3323,7 +3323,7 @@ static void i40iw_init_tcp_ctx(struct i40iw_cm_node *cm_node, tcp_info->flow_label = 0; tcp_info->snd_mss = cpu_to_le32(((u32)cm_node->tcp_cntxt.mss)); - if (cm_node->vlan_id < VLAN_TAG_PRESENT) { + if (cm_node->vlan_id <= VLAN_VID_MASK) { tcp_info->insert_vlan_tag = true; tcp_info->vlan_tag = cpu_to_le16(((u16)cm_node->user_pri << I40IW_VLAN_PRIO_SHIFT) | cm_node->vlan_id); -- 2.19.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH net-next 3/4] gianfar: remove use of VLAN_TAG_PRESENT 2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław 2018-11-08 17:44 ` [PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT Michał Mirosław @ 2018-11-08 17:44 ` Michał Mirosław 2018-11-08 17:44 ` [PATCH net-next 2/4] cnic: " Michał Mirosław ` (4 subsequent siblings) 6 siblings, 0 replies; 9+ messages in thread From: Michał Mirosław @ 2018-11-08 17:44 UTC (permalink / raw) To: netdev Cc: Claudiu Manoil, Faisal Latif, Pravin B Shelar, Shiraz Saleem, dev, linux-rdma Reviewed-by: Claudiu Manoil <claudiu.manoil@nxp.com> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- drivers/net/ethernet/freescale/gianfar_ethtool.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c index 0d76e15cd6dd..241325c35cb4 100644 --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c @@ -1134,11 +1134,9 @@ static int gfar_convert_to_filer(struct ethtool_rx_flow_spec *rule, prio = vlan_tci_prio(rule); prio_mask = vlan_tci_priom(rule); - if (cfi == VLAN_TAG_PRESENT && cfi_mask == VLAN_TAG_PRESENT) { - vlan |= RQFPR_CFI; - vlan_mask |= RQFPR_CFI; - } else if (cfi != VLAN_TAG_PRESENT && - cfi_mask == VLAN_TAG_PRESENT) { + if (cfi_mask) { + if (cfi) + vlan |= RQFPR_CFI; vlan_mask |= RQFPR_CFI; } } -- 2.19.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH net-next 2/4] cnic: remove use of VLAN_TAG_PRESENT 2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław 2018-11-08 17:44 ` [PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT Michał Mirosław 2018-11-08 17:44 ` [PATCH net-next 3/4] gianfar: " Michał Mirosław @ 2018-11-08 17:44 ` Michał Mirosław 2018-11-08 17:44 ` [PATCH net-next 4/4] OVS: " Michał Mirosław ` (3 subsequent siblings) 6 siblings, 0 replies; 9+ messages in thread From: Michał Mirosław @ 2018-11-08 17:44 UTC (permalink / raw) To: netdev Cc: Claudiu Manoil, Faisal Latif, Pravin B Shelar, Shiraz Saleem, dev, linux-rdma This just removes VLAN_TAG_PRESENT use. VLAN TCI=0 special meaning is deeply embedded in the driver code and so is left as is. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- drivers/net/ethernet/broadcom/cnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/cnic.c b/drivers/net/ethernet/broadcom/cnic.c index d83233ae4a15..510dfc1c236b 100644 --- a/drivers/net/ethernet/broadcom/cnic.c +++ b/drivers/net/ethernet/broadcom/cnic.c @@ -5731,7 +5731,7 @@ static int cnic_netdev_event(struct notifier_block *this, unsigned long event, if (realdev) { dev = cnic_from_netdev(realdev); if (dev) { - vid |= VLAN_TAG_PRESENT; + vid |= VLAN_CFI_MASK; /* make non-zero */ cnic_rcv_netevent(dev->cnic_priv, event, vid); cnic_put(dev); } -- 2.19.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH net-next 4/4] OVS: remove use of VLAN_TAG_PRESENT 2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław ` (2 preceding siblings ...) 2018-11-08 17:44 ` [PATCH net-next 2/4] cnic: " Michał Mirosław @ 2018-11-08 17:44 ` Michał Mirosław [not found] ` <cover.1541698641.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> ` (2 subsequent siblings) 6 siblings, 0 replies; 9+ messages in thread From: Michał Mirosław @ 2018-11-08 17:44 UTC (permalink / raw) To: netdev Cc: Pravin B Shelar, Claudiu Manoil, Faisal Latif, Shiraz Saleem, dev, linux-rdma This is a minimal change to allow removing of VLAN_TAG_PRESENT. It leaves OVS unable to use CFI bit, as fixing this would need a deeper surgery involving userspace interface. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- net/openvswitch/actions.c | 13 +++++++++---- net/openvswitch/flow.c | 4 ++-- net/openvswitch/flow.h | 2 +- net/openvswitch/flow_netlink.c | 22 +++++++++++----------- 4 files changed, 23 insertions(+), 18 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index 85ae53d8fd09..e47ebbbe71b8 100644 --- a/net/openvswitch/actions.c +++ b/net/openvswitch/actions.c @@ -301,7 +301,7 @@ static int push_vlan(struct sk_buff *skb, struct sw_flow_key *key, key->eth.vlan.tpid = vlan->vlan_tpid; } return skb_vlan_push(skb, vlan->vlan_tpid, - ntohs(vlan->vlan_tci) & ~VLAN_TAG_PRESENT); + ntohs(vlan->vlan_tci) & ~VLAN_CFI_MASK); } /* 'src' is already properly masked. */ @@ -822,8 +822,10 @@ static int ovs_vport_output(struct net *net, struct sock *sk, struct sk_buff *sk __skb_dst_copy(skb, data->dst); *OVS_CB(skb) = data->cb; skb->inner_protocol = data->inner_protocol; - skb->vlan_tci = data->vlan_tci; - skb->vlan_proto = data->vlan_proto; + if (data->vlan_tci & VLAN_CFI_MASK) + __vlan_hwaccel_put_tag(skb, data->vlan_proto, data->vlan_tci & ~VLAN_CFI_MASK); + else + __vlan_hwaccel_clear_tag(skb); /* Reconstruct the MAC header. */ skb_push(skb, data->l2_len); @@ -867,7 +869,10 @@ static void prepare_frag(struct vport *vport, struct sk_buff *skb, data->cb = *OVS_CB(skb); data->inner_protocol = skb->inner_protocol; data->network_offset = orig_network_offset; - data->vlan_tci = skb->vlan_tci; + if (skb_vlan_tag_present(skb)) + data->vlan_tci = skb_vlan_tag_get(skb) | VLAN_CFI_MASK; + else + data->vlan_tci = 0; data->vlan_proto = skb->vlan_proto; data->mac_proto = mac_proto; data->l2_len = hlen; diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c index 35966da84769..fa393815991e 100644 --- a/net/openvswitch/flow.c +++ b/net/openvswitch/flow.c @@ -325,7 +325,7 @@ static int parse_vlan_tag(struct sk_buff *skb, struct vlan_head *key_vh, return -ENOMEM; vh = (struct vlan_head *)skb->data; - key_vh->tci = vh->tci | htons(VLAN_TAG_PRESENT); + key_vh->tci = vh->tci | htons(VLAN_CFI_MASK); key_vh->tpid = vh->tpid; if (unlikely(untag_vlan)) { @@ -358,7 +358,7 @@ static int parse_vlan(struct sk_buff *skb, struct sw_flow_key *key) int res; if (skb_vlan_tag_present(skb)) { - key->eth.vlan.tci = htons(skb->vlan_tci); + key->eth.vlan.tci = htons(skb->vlan_tci) | htons(VLAN_CFI_MASK); key->eth.vlan.tpid = skb->vlan_proto; } else { /* Parse outer vlan tag in the non-accelerated case. */ diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h index c670dd24b8b7..ba01fc4270bd 100644 --- a/net/openvswitch/flow.h +++ b/net/openvswitch/flow.h @@ -60,7 +60,7 @@ struct ovs_tunnel_info { struct vlan_head { __be16 tpid; /* Vlan type. Generally 802.1q or 802.1ad.*/ - __be16 tci; /* 0 if no VLAN, VLAN_TAG_PRESENT set otherwise. */ + __be16 tci; /* 0 if no VLAN, VLAN_CFI_MASK set otherwise. */ }; #define OVS_SW_FLOW_KEY_METADATA_SIZE \ diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index 865ecef68196..435a4bdf8f89 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch/flow_netlink.c @@ -990,9 +990,9 @@ static int validate_vlan_from_nlattrs(const struct sw_flow_match *match, if (a[OVS_KEY_ATTR_VLAN]) tci = nla_get_be16(a[OVS_KEY_ATTR_VLAN]); - if (!(tci & htons(VLAN_TAG_PRESENT))) { + if (!(tci & htons(VLAN_CFI_MASK))) { if (tci) { - OVS_NLERR(log, "%s TCI does not have VLAN_TAG_PRESENT bit set.", + OVS_NLERR(log, "%s TCI does not have VLAN_CFI_MASK bit set.", (inner) ? "C-VLAN" : "VLAN"); return -EINVAL; } else if (nla_len(a[OVS_KEY_ATTR_ENCAP])) { @@ -1013,9 +1013,9 @@ static int validate_vlan_mask_from_nlattrs(const struct sw_flow_match *match, __be16 tci = 0; __be16 tpid = 0; bool encap_valid = !!(match->key->eth.vlan.tci & - htons(VLAN_TAG_PRESENT)); + htons(VLAN_CFI_MASK)); bool i_encap_valid = !!(match->key->eth.cvlan.tci & - htons(VLAN_TAG_PRESENT)); + htons(VLAN_CFI_MASK)); if (!(key_attrs & (1 << OVS_KEY_ATTR_ENCAP))) { /* Not a VLAN. */ @@ -1039,8 +1039,8 @@ static int validate_vlan_mask_from_nlattrs(const struct sw_flow_match *match, (inner) ? "C-VLAN" : "VLAN", ntohs(tpid)); return -EINVAL; } - if (!(tci & htons(VLAN_TAG_PRESENT))) { - OVS_NLERR(log, "%s TCI mask does not have exact match for VLAN_TAG_PRESENT bit.", + if (!(tci & htons(VLAN_CFI_MASK))) { + OVS_NLERR(log, "%s TCI mask does not have exact match for VLAN_CFI_MASK bit.", (inner) ? "C-VLAN" : "VLAN"); return -EINVAL; } @@ -1095,7 +1095,7 @@ static int parse_vlan_from_nlattrs(struct sw_flow_match *match, if (err) return err; - encap_valid = !!(match->key->eth.vlan.tci & htons(VLAN_TAG_PRESENT)); + encap_valid = !!(match->key->eth.vlan.tci & htons(VLAN_CFI_MASK)); if (encap_valid) { err = __parse_vlan_from_nlattrs(match, key_attrs, true, a, is_mask, log); @@ -2943,7 +2943,7 @@ static int __ovs_nla_copy_actions(struct net *net, const struct nlattr *attr, vlan = nla_data(a); if (!eth_type_vlan(vlan->vlan_tpid)) return -EINVAL; - if (!(vlan->vlan_tci & htons(VLAN_TAG_PRESENT))) + if (!(vlan->vlan_tci & htons(VLAN_CFI_MASK))) return -EINVAL; vlan_tci = vlan->vlan_tci; break; @@ -2959,7 +2959,7 @@ static int __ovs_nla_copy_actions(struct net *net, const struct nlattr *attr, /* Prohibit push MPLS other than to a white list * for packets that have a known tag order. */ - if (vlan_tci & htons(VLAN_TAG_PRESENT) || + if (vlan_tci & htons(VLAN_CFI_MASK) || (eth_type != htons(ETH_P_IP) && eth_type != htons(ETH_P_IPV6) && eth_type != htons(ETH_P_ARP) && @@ -2971,7 +2971,7 @@ static int __ovs_nla_copy_actions(struct net *net, const struct nlattr *attr, } case OVS_ACTION_ATTR_POP_MPLS: - if (vlan_tci & htons(VLAN_TAG_PRESENT) || + if (vlan_tci & htons(VLAN_CFI_MASK) || !eth_p_mpls(eth_type)) return -EINVAL; @@ -3036,7 +3036,7 @@ static int __ovs_nla_copy_actions(struct net *net, const struct nlattr *attr, case OVS_ACTION_ATTR_POP_ETH: if (mac_proto != MAC_PROTO_ETHERNET) return -EINVAL; - if (vlan_tci & htons(VLAN_TAG_PRESENT)) + if (vlan_tci & htons(VLAN_CFI_MASK)) return -EINVAL; mac_proto = MAC_PROTO_NONE; break; -- 2.19.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <cover.1541698641.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>]
* Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers [not found] ` <cover.1541698641.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> @ 2018-11-08 18:50 ` Leon Romanovsky 2018-11-08 22:11 ` Michał Mirosław 0 siblings, 1 reply; 9+ messages in thread From: Leon Romanovsky @ 2018-11-08 18:50 UTC (permalink / raw) To: Michał Mirosław Cc: dev-yBygre7rU0TnMu66kgdUjQ, Faisal Latif, linux-rdma-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, Claudiu Manoil, Shiraz Saleem [-- Attachment #1.1: Type: text/plain, Size: 1100 bytes --] On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote: > This series removes VLAN_TAG_PRESENT use from network drivers in > preparation to removing its special meaning. Can you please give an extra explanation why it is removed? Such series come out-of-blue, for people who are not following netdev mailing list closely (drivers/infiniband/*). Thanks > > Michał Mirosław (4): > i40iw: remove use of VLAN_TAG_PRESENT > cnic: remove use of VLAN_TAG_PRESENT > gianfar: remove use of VLAN_TAG_PRESENT > OVS: remove use of VLAN_TAG_PRESENT > > drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 +++---- > drivers/net/ethernet/broadcom/cnic.c | 2 +- > .../net/ethernet/freescale/gianfar_ethtool.c | 8 +++---- > net/openvswitch/actions.c | 13 +++++++---- > net/openvswitch/flow.c | 4 ++-- > net/openvswitch/flow.h | 2 +- > net/openvswitch/flow_netlink.c | 22 +++++++++---------- > 7 files changed, 31 insertions(+), 28 deletions(-) > > -- > 2.19.1 > [-- Attachment #2: Type: text/plain, Size: 0 bytes --] ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers 2018-11-08 18:50 ` [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Leon Romanovsky @ 2018-11-08 22:11 ` Michał Mirosław 0 siblings, 0 replies; 9+ messages in thread From: Michał Mirosław @ 2018-11-08 22:11 UTC (permalink / raw) To: Leon Romanovsky Cc: netdev, Claudiu Manoil, Faisal Latif, Pravin B Shelar, Shiraz Saleem, dev, linux-rdma On Thu, Nov 08, 2018 at 08:50:05PM +0200, Leon Romanovsky wrote: > On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote: > > This series removes VLAN_TAG_PRESENT use from network drivers in > > preparation to removing its special meaning. > Can you please give an extra explanation why it is removed? > Such series come out-of-blue, for people who are not following > netdev mailing list closely (drivers/infiniband/*). This is one of the steps to remove VLAN_TAG_PRESENT overlap with CFI/DEI bit of VLAN tag. Currently this overlap causes Linux kernel to always clear CFI/DEI in packets. There is skb_vlan_tag_present() that drivers should use to check if the tag in skb is valid. Best Regards, Michał Mirosław ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers 2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław ` (4 preceding siblings ...) [not found] ` <cover.1541698641.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org> @ 2018-11-09 3:49 ` David Miller 2018-11-09 21:58 ` Shiraz Saleem 6 siblings, 0 replies; 9+ messages in thread From: David Miller @ 2018-11-09 3:49 UTC (permalink / raw) To: mirq-linux Cc: netdev, claudiu.manoil, faisal.latif, pshelar, shiraz.saleem, dev, linux-rdma From: Michał Mirosław <mirq-linux@rere.qmqm.pl> Date: Thu, 08 Nov 2018 18:44:46 +0100 > This series removes VLAN_TAG_PRESENT use from network drivers in > preparation to removing its special meaning. Series applied, thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers 2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław ` (5 preceding siblings ...) 2018-11-09 3:49 ` David Miller @ 2018-11-09 21:58 ` Shiraz Saleem 6 siblings, 0 replies; 9+ messages in thread From: Shiraz Saleem @ 2018-11-09 21:58 UTC (permalink / raw) To: Michał Mirosław Cc: netdev, Claudiu Manoil, Faisal Latif, Pravin B Shelar, dev, linux-rdma On Thu, Nov 08, 2018 at 06:44:46PM +0100, Michał Mirosław wrote: > This series removes VLAN_TAG_PRESENT use from network drivers in > preparation to removing its special meaning. > > Michał Mirosław (4): > i40iw: remove use of VLAN_TAG_PRESENT > cnic: remove use of VLAN_TAG_PRESENT > gianfar: remove use of VLAN_TAG_PRESENT > OVS: remove use of VLAN_TAG_PRESENT > > drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 +++---- > i40iw bit looks fine. Thanks! Acked-by: Shiraz Saleem <shiraz.saleem@intel.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-10 7:41 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-08 17:44 [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Michał Mirosław
2018-11-08 17:44 ` [PATCH net-next] i40iw: remove use of VLAN_TAG_PRESENT Michał Mirosław
2018-11-08 17:44 ` [PATCH net-next 3/4] gianfar: " Michał Mirosław
2018-11-08 17:44 ` [PATCH net-next 2/4] cnic: " Michał Mirosław
2018-11-08 17:44 ` [PATCH net-next 4/4] OVS: " Michał Mirosław
[not found] ` <cover.1541698641.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
2018-11-08 18:50 ` [PATCH net-next 0/4] Remove VLAN_TAG_PRESENT from drivers Leon Romanovsky
2018-11-08 22:11 ` Michał Mirosław
2018-11-09 3:49 ` David Miller
2018-11-09 21:58 ` Shiraz Saleem
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).