* [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation
@ 2018-11-08 19:47 Edward Cree
2018-11-08 20:13 ` Eric Dumazet
2018-11-09 4:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Edward Cree @ 2018-11-08 19:47 UTC (permalink / raw)
To: linux-net-drivers, davem; +Cc: netdev
As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which
see for performance rationale.
Signed-off-by: Edward Cree <ecree@solarflare.com>
---
drivers/net/ethernet/sfc/tx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
index c3ad564ac4c0..22eb059086f7 100644
--- a/drivers/net/ethernet/sfc/tx.c
+++ b/drivers/net/ethernet/sfc/tx.c
@@ -553,13 +553,10 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
if (!data_mapped && (efx_tx_map_data(tx_queue, skb, segments)))
goto err;
- /* Update BQL */
- netdev_tx_sent_queue(tx_queue->core_txq, skb_len);
-
efx_tx_maybe_stop_queue(tx_queue);
/* Pass off to hardware */
- if (!xmit_more || netif_xmit_stopped(tx_queue->core_txq)) {
+ if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more)) {
struct efx_tx_queue *txq2 = efx_tx_queue_partner(tx_queue);
/* There could be packets left on the partner queue if those
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation
2018-11-08 19:47 [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation Edward Cree
@ 2018-11-08 20:13 ` Eric Dumazet
2018-11-09 4:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-11-08 20:13 UTC (permalink / raw)
To: Edward Cree, linux-net-drivers, davem; +Cc: netdev
On 11/08/2018 11:47 AM, Edward Cree wrote:
> As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which
> see for performance rationale.
>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
> ---
> drivers/net/ethernet/sfc/tx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c
> index c3ad564ac4c0..22eb059086f7 100644
> --- a/drivers/net/ethernet/sfc/tx.c
> +++ b/drivers/net/ethernet/sfc/tx.c
> @@ -553,13 +553,10 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb)
> if (!data_mapped && (efx_tx_map_data(tx_queue, skb, segments)))
> goto err;
>
> - /* Update BQL */
> - netdev_tx_sent_queue(tx_queue->core_txq, skb_len);
> -
> efx_tx_maybe_stop_queue(tx_queue);
>
> /* Pass off to hardware */
> - if (!xmit_more || netif_xmit_stopped(tx_queue->core_txq)) {
> + if (__netdev_tx_sent_queue(tx_queue->core_txq, skb_len, xmit_more)) {
> struct efx_tx_queue *txq2 = efx_tx_queue_partner(tx_queue);
>
> /* There could be packets left on the partner queue if those
>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks !
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation
2018-11-08 19:47 [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation Edward Cree
2018-11-08 20:13 ` Eric Dumazet
@ 2018-11-09 4:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-11-09 4:01 UTC (permalink / raw)
To: ecree; +Cc: linux-net-drivers, netdev
From: Edward Cree <ecree@solarflare.com>
Date: Thu, 8 Nov 2018 19:47:19 +0000
> As added in 3e59020abf0f ("net: bql: add __netdev_tx_sent_queue()"), which
> see for performance rationale.
>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-09 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-08 19:47 [PATCH net-next] sfc: use the new __netdev_tx_sent_queue BQL optimisation Edward Cree
2018-11-08 20:13 ` Eric Dumazet
2018-11-09 4:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).