From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com
Subject: Re: [PATCH net-next 0/7] nfp: abm: move code and improve parameter validation
Date: Thu, 08 Nov 2018 20:49:29 -0800 (PST) [thread overview]
Message-ID: <20181108.204929.2004608845629526400.davem@davemloft.net> (raw)
In-Reply-To: <20181109035039.25823-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 8 Nov 2018 19:50:32 -0800
> This set starts by separating Qdisc handling code into a new file.
> Next two patches allow early access to TLV-based capabilities during
> probe, previously the capabilities were parsed just before netdevs
> were registered, but its cleaner to do some basic validation earlier
> and avoid cleanup work.
>
> Next three patches improve RED's parameter validation. First we provide
> a more precise message about why offload failed (and move the parameter
> validation to a helper). Next we make sure we don't set the top bit
> in the 32 bit max RED threshold value. Because FW is treating the value
> as signed it reportedly causes slow downs (unnecessary queuing and
> marking) when top bit is set with recent firmwares. Last (and perhaps
> least importantly) we offload the harddrop parameter of the Qdisc.
> We don't plan to offload harddrop RED, but it seems prudent to make
> sure user didn't set that flag as device behaviour would have differed.
Series applied, thanks Jakub.
prev parent reply other threads:[~2018-11-09 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 3:50 [PATCH net-next 0/7] nfp: abm: move code and improve parameter validation Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 1/7] nfp: abm: split qdisc offload code into a separate file Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 2/7] nfp: pass ctrl_bar pointer to nfp_net_alloc Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 3/7] nfp: parse vNIC TLV capabilities at alloc time Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 4/7] nfp: abm: provide more precise info about offload parameter validation Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 5/7] nfp: abm: don't set negative threshold Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 6/7] net: sched: red: inform offloads about harddrop setting Jakub Kicinski
2018-11-09 3:50 ` [PATCH net-next 7/7] nfp: abm: refuse RED offload with harddrop set Jakub Kicinski
2018-11-09 4:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108.204929.2004608845629526400.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).