From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/7] nfp: abm: move code and improve parameter validation Date: Thu, 08 Nov 2018 20:49:29 -0800 (PST) Message-ID: <20181108.204929.2004608845629526400.davem@davemloft.net> References: <20181109035039.25823-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43226 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727474AbeKIO2T (ORCPT ); Fri, 9 Nov 2018 09:28:19 -0500 In-Reply-To: <20181109035039.25823-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Thu, 8 Nov 2018 19:50:32 -0800 > This set starts by separating Qdisc handling code into a new file. > Next two patches allow early access to TLV-based capabilities during > probe, previously the capabilities were parsed just before netdevs > were registered, but its cleaner to do some basic validation earlier > and avoid cleanup work. > > Next three patches improve RED's parameter validation. First we provide > a more precise message about why offload failed (and move the parameter > validation to a helper). Next we make sure we don't set the top bit > in the 32 bit max RED threshold value. Because FW is treating the value > as signed it reportedly causes slow downs (unnecessary queuing and > marking) when top bit is set with recent firmwares. Last (and perhaps > least importantly) we offload the harddrop parameter of the Qdisc. > We don't plan to offload harddrop RED, but it seems prudent to make > sure user didn't set that flag as device behaviour would have differed. Series applied, thanks Jakub.