From: Phil Sutter <phil@nwl.cc>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
nikolay@cumulusnetworks.com, dsahern@gmail.com
Subject: Re: [PATCH iproute2] bridge: fdb: remove redundant dev string in show output
Date: Thu, 8 Nov 2018 10:35:05 +0100 [thread overview]
Message-ID: <20181108093505.GK6440@orbyte.nwl.cc> (raw)
In-Reply-To: <1541632449-9993-1-git-send-email-roopa@cumulusnetworks.com>
Hi Roopa,
On Wed, Nov 07, 2018 at 03:14:09PM -0800, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> After commit 4abb8c723a64 ("bridge: fdb: Fix for missing
> keywords in non-JSON output"), I am seeing a double print for dev
> in bridge fdb show. eg:
> "44:38:39:00:6a:82 dev dev bridge vlan 1 master bridge permanent"
>
> this patch removes the redundant print.
>
> Fixes: 4abb8c723a64 ("bridge: fdb: Fix for missing keywords in non-JSON output")
Oh, stupid mistake. :(
Thanks for the fix!
> CC: Phil Sutter <phil@nwl.cc>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Acked-by: Phil Sutter <phil@nwl.cc>
next prev parent reply other threads:[~2018-11-08 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 23:14 [PATCH iproute2] bridge: fdb: remove redundant dev string in show output Roopa Prabhu
2018-11-08 9:35 ` Phil Sutter [this message]
2018-11-09 15:54 ` Stephen Hemminger
2018-11-09 16:05 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108093505.GK6440@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).