From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH v3 bpf-next 4/4] bpftool: support loading flow dissector
Date: Thu, 8 Nov 2018 11:45:44 -0800
Message-ID: <20181108114544.1ac0cd44@cakuba.hsd1.ca.comcast.net>
References: <20181108053957.205681-1-sdf@google.com>
        <20181108053957.205681-5-sdf@google.com>
        <8c35340e-3ed7-70cd-3123-7cd0fb8824a7@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Stanislav Fomichev <sdf@google.com>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, ast@kernel.org,
        daniel@iogearbox.net, shuah@kernel.org, guro@fb.com,
        jiong.wang@netronome.com, bhole_prashant_q7@lab.ntt.co.jp,
        john.fastabend@gmail.com, jbenc@redhat.com,
        treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com,
        sandipan@linux.vnet.ibm.com
To: Quentin Monnet <quentin.monnet@netronome.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qk1-f196.google.com ([209.85.222.196]:35066 "EHLO
        mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725922AbeKIFWs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Nov 2018 00:22:48 -0500
Received: by mail-qk1-f196.google.com with SMTP id w204so3676122qka.2
        for <netdev@vger.kernel.org>; Thu, 08 Nov 2018 11:45:51 -0800 (PST)
In-Reply-To: <8c35340e-3ed7-70cd-3123-7cd0fb8824a7@netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, 8 Nov 2018 11:16:43 +0000, Quentin Monnet wrote:
> > -	bpf_program__set_ifindex(prog, ifindex);
> >   	if (attr.prog_type == BPF_PROG_TYPE_UNSPEC) {
> > +		if (!prog) {
> > +			p_err("can not guess program type when loading all programs\n");

No new lines in p_err(), beaks JSON.

> > +			goto err_close_obj;
> > +		}
> > +
> >   		const char *sec_name = bpf_program__title(prog, false);
> >   
> >   		err = libbpf_prog_type_by_name(sec_name, &attr.prog_type,
> > @@ -936,8 +958,13 @@ static int do_load(int argc, char **argv)
> >   			goto err_close_obj;
> >   		}
> >   	}
> > -	bpf_program__set_type(prog, attr.prog_type);
> > -	bpf_program__set_expected_attach_type(prog, expected_attach_type);
> > +
> > +	bpf_object__for_each_program(pos, obj) {
> > +		bpf_program__set_ifindex(pos, ifindex);
> > +		bpf_program__set_type(pos, attr.prog_type);
> > +		bpf_program__set_expected_attach_type(pos,
> > +						      expected_attach_type);
> > +	}  
> 
> I still believe you can have programs of different types here, and be 
> able to load them. I tried it and managed to have it working fine. If no 
> type is provided from command line we can retrieve types for each 
> program from its section name. If a type is provided on the command 
> line, we can do the same, but I am not sure we should do it, or impose 
> that type for all programs instead.

attr->prog_type is one per object, though.  How do we set that one?