From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 2/2] net: phy: realtek: remove boilerplate code
 from driver configs
Date: Thu, 8 Nov 2018 19:37:21 +0100
Message-ID: <20181108183721.GE5259@lunn.ch>
References: <08d52675-f308-4ebb-4ec4-f6c7ac0b6b06@gmail.com>
 <7f3b2935-f6d3-f7f6-fb42-4fe40d381cc6@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:55663 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727382AbeKIEmJ (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 8 Nov 2018 23:42:09 -0500
Content-Disposition: inline
In-Reply-To: <7f3b2935-f6d3-f7f6-fb42-4fe40d381cc6@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

>  	{
>  		.phy_id         = 0x00008201,
>  		.name           = "RTL8201CP Ethernet",
> -		.phy_id_mask    = 0x0000ffff,
>  		.features       = PHY_BASIC_FEATURES,
>  		.flags          = PHY_HAS_INTERRUPT,
>  	}, {
>  		.phy_id		= 0x001cc816,
>  		.name		= "RTL8201F Fast Ethernet",
> -		.phy_id_mask	= 0x001fffff,

Hi Heiner

"RTL8201CP Ethernet" has a mask of 0x0000ffff, where as all the others
use 0x001fffff. Is this correct?

    Andrew