From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Roeschley Subject: Re: [PATCH] net: phy: leds: Don't make our own link speed names Date: Thu, 8 Nov 2018 19:32:28 +0000 Message-ID: <20181108193226.GA26998@senary> References: <20181108175106.25684-1-kyle.roeschley@ni.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Andrew Lunn , "David S . Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Florian Fainelli Return-path: In-Reply-To: Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Nov 08, 2018 at 09:59:53AM -0800, Florian Fainelli wrote: > On 11/8/18 9:51 AM, Kyle Roeschley wrote: > > The phy core provides a handy phy_speed_to_str() helper, so use that > > instead of doing our own formatting of the different known link speeds. >=20 > In case the speed is not supported, phy_speed_to_str() would return > "Unsupported (update phy-core.c)" which is bigger (by 21 characters) > than name_suffix. >=20 > If you bumped name_suffix/PHY_LED_TRIGGER_SPEED_SUFFIX_SIZE to 11 > characters, that would be just large enough to accommodate for the > "Unsupported" part of the string and that might be an acceptable > solution in between. >=20 Thanks for catching that, I'll send a v2. --=20 Kyle Roeschley Software Engineer National Instruments