From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH v4 bpf-next 2/7] libbpf: cleanup after partial failure
 in bpf_object__pin
Date: Thu, 8 Nov 2018 19:37:05 -0800
Message-ID: <20181108193705.2933c2bc@cakuba.netronome.com>
References: <20181109002213.5914-1-s@fomichev.me>
        <20181109002213.5914-3-s@fomichev.me>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org,
        quentin.monnet@netronome.com, guro@fb.com,
        jiong.wang@netronome.com, sdf@google.com,
        bhole_prashant_q7@lab.ntt.co.jp, john.fastabend@gmail.com,
        jbenc@redhat.com, treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com,
        sandipan@linux.vnet.ibm.com
To: Stanislav Fomichev <sdf@fomichev.me>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-yw1-f50.google.com ([209.85.161.50]:46310 "EHLO
        mail-yw1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727445AbeKINPw (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Nov 2018 08:15:52 -0500
Received: by mail-yw1-f50.google.com with SMTP id v5-v6so709339ywa.13
        for <netdev@vger.kernel.org>; Thu, 08 Nov 2018 19:37:12 -0800 (PST)
In-Reply-To: <20181109002213.5914-3-s@fomichev.me>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu,  8 Nov 2018 16:22:08 -0800, Stanislav Fomichev wrote:
> +	for (map = bpf_map__prev(map, obj);
> +	     map != NULL;
> +	     map = bpf_map__prev(map, obj)) {

nit pick: if you need to respin all these for loops on error paths could
          have been more concise while loops