From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH v4 bpf-next 4/7] libbpf: add internal pin_name
Date: Thu, 8 Nov 2018 19:38:56 -0800
Message-ID: <20181108193712.754659d7@cakuba.netronome.com>
References: <20181109002213.5914-1-s@fomichev.me>
        <20181109002213.5914-5-s@fomichev.me>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org,
        quentin.monnet@netronome.com, guro@fb.com,
        jiong.wang@netronome.com, sdf@google.com,
        bhole_prashant_q7@lab.ntt.co.jp, john.fastabend@gmail.com,
        jbenc@redhat.com, treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com,
        sandipan@linux.vnet.ibm.com
To: Stanislav Fomichev <sdf@fomichev.me>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-yb1-f196.google.com ([209.85.219.196]:43916 "EHLO
        mail-yb1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727604AbeKINRl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 9 Nov 2018 08:17:41 -0500
Received: by mail-yb1-f196.google.com with SMTP id h187-v6so378842ybg.10
        for <netdev@vger.kernel.org>; Thu, 08 Nov 2018 19:39:01 -0800 (PST)
In-Reply-To: <20181109002213.5914-5-s@fomichev.me>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu,  8 Nov 2018 16:22:10 -0800, Stanislav Fomichev wrote:
> @@ -261,6 +266,18 @@ static void bpf_program__exit(struct bpf_program *prog)
>  	prog->idx = -1;
>  }
>  
> +static char *__bpf_program__pin_name(struct bpf_program *prog)
> +{
> +	char *name;
> +
> +	name = strdup(prog->section_name);
> +	for (char *p = name; p && *p; p++)

Useful patch!  I'm not sure about libbpf but in the kernel we don't do
C99 variable declarations inside for loop init.  Perhaps better to stick
to kernel rules than invent our own.

Also, I'm tempted to say:

	char *name, *p;

	name = p = strdup(prog->section_name);
	while ((p = strchr(p, '/')))
		*p = '_';

;)

> +		if (*p == '/')
> +			*p = '_';
> +
> +	return name;
> +}