From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH v4 bpf-next 5/7] bpftool: add loadall command Date: Thu, 8 Nov 2018 19:41:19 -0800 Message-ID: <20181108194119.0c75343e@cakuba.netronome.com> References: <20181109002213.5914-1-s@fomichev.me> <20181109002213.5914-6-s@fomichev.me> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org, quentin.monnet@netronome.com, guro@fb.com, jiong.wang@netronome.com, sdf@google.com, bhole_prashant_q7@lab.ntt.co.jp, john.fastabend@gmail.com, jbenc@redhat.com, treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com, sandipan@linux.vnet.ibm.com To: Stanislav Fomichev Return-path: Received: from mail-yw1-f43.google.com ([209.85.161.43]:36787 "EHLO mail-yw1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727391AbeKINUH (ORCPT ); Fri, 9 Nov 2018 08:20:07 -0500 Received: by mail-yw1-f43.google.com with SMTP id h21-v6so800524ywa.3 for ; Thu, 08 Nov 2018 19:41:27 -0800 (PST) In-Reply-To: <20181109002213.5914-6-s@fomichev.me> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 8 Nov 2018 16:22:11 -0800, Stanislav Fomichev wrote: > @@ -79,8 +80,13 @@ DESCRIPTION > contain a dot character ('.'), which is reserved for future > extensions of *bpffs*. > > - **bpftool prog load** *OBJ* *FILE* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] > - Load bpf program from binary *OBJ* and pin as *FILE*. > + **bpftool prog { load | loadall }** *OBJ* *FILE* [**type** *TYPE*] [**map** {**idx** *IDX* | **name** *NAME*} *MAP*] [**dev** *NAME*] > + Load bpf program(s) from binary *OBJ* and pin as *FILE*. > + Both **bpftool prog load** and **bpftool prog loadall** load > + all maps and programs from the *OBJ* and differ only in > + pinning. **load** pins only the first program from the *OBJ* > + as *FILE*. **loadall** pins all programs from the *OBJ* > + under *FILE* directory. > **type** is optional, if not specified program type will be > inferred from section names. > By default bpftool will create new maps as declared in the ELF As I said the fact that we load all always is a libbpf limitation, I wouldn't put it in documentation as it may change. With that removed looks good to me: Acked-by: Jakub Kicinski