From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [Patch net-next] net: move __skb_checksum_complete*() to skbuff.c Date: Thu, 8 Nov 2018 20:54:13 +0100 Message-ID: <20181108205413.2008a004@redhat.com> References: <20181108194949.11866-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: Cong Wang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48626 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726140AbeKIFbS (ORCPT ); Fri, 9 Nov 2018 00:31:18 -0500 In-Reply-To: <20181108194949.11866-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi, On Thu, 8 Nov 2018 11:49:49 -0800 Cong Wang wrote: > +EXPORT_SYMBOL(__skb_checksum_complete); > + > /* Both of above in one bottle. */ Maybe you should also update/drop this comment now? > __wsum skb_copy_and_csum_bits(const struct sk_buff *skb, int offset, -- Stefano