From: Stefano Brivio <sbrivio@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [Patch net-next] net: move __skb_checksum_complete*() to skbuff.c
Date: Thu, 8 Nov 2018 21:14:35 +0100 [thread overview]
Message-ID: <20181108211435.1f8d953f@redhat.com> (raw)
In-Reply-To: <CAM_iQpXh03pCAp-t-Zh-etTPRbiBwCSuJLL5LTfr5EK0CT=Qzg@mail.gmail.com>
On Thu, 8 Nov 2018 12:02:00 -0800
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> On Thu, Nov 8, 2018 at 11:54 AM Stefano Brivio <sbrivio@redhat.com> wrote:
> >
> > Hi,
> >
> > On Thu, 8 Nov 2018 11:49:49 -0800
> > Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > > +EXPORT_SYMBOL(__skb_checksum_complete);
> > > +
> > > /* Both of above in one bottle. */
> >
> > Maybe you should also update/drop this comment now?
>
> I have no idea what that comment means. Do you?
I think it refers to the fact that skb_copy_and_csum_bits() implements
both skb_checksum() and skb_copy_bits(), that were just above it at
1da177e4c3f4.
Then more stuff was moved in between, and the comment was never updated
or dropped.
--
Stefano
next prev parent reply other threads:[~2018-11-09 5:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 19:49 [Patch net-next] net: move __skb_checksum_complete*() to skbuff.c Cong Wang
2018-11-08 19:54 ` Stefano Brivio
2018-11-08 20:02 ` Cong Wang
2018-11-08 20:14 ` Stefano Brivio [this message]
2018-11-08 20:26 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181108211435.1f8d953f@redhat.com \
--to=sbrivio@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).