From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for
 FW DMAE transactions.
Date: Fri, 09 Nov 2018 15:22:02 -0800 (PST)
Message-ID: <20181109.152202.1670898351591745529.davem@davemloft.net>
References: <20181109101043.22373-1-sudarsana.kalluru@cavium.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Michal.Kalderon@cavium.com
To: sudarsana.kalluru@cavium.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:32856 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727012AbeKJJEt (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 10 Nov 2018 04:04:49 -0500
In-Reply-To: <20181109101043.22373-1-sudarsana.kalluru@cavium.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@cavium.com>
Date: Fri, 9 Nov 2018 02:10:43 -0800

> +/* Following is the DMAE channel number allocation for the clients.
> + *   MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively.
> + *   Driver: 0-3 and 8-11 (for PF dmae operations)
> + *           4 and 12 (for stats requests)
> + */
> +#define BNX2X_FW_DMAE_C                 13 /* Channel for FW DMAE operations */
 ...
> +	start_params->dmae_cmd_id = BNX2X_FW_DMAE_C;

Why do you need this, it never changes, and:

> +	rdata->dmae_cmd_id	= start_params->dmae_cmd_id;

It always is the same value here in the one place it is used.

Just assign BNX2X_FW_DMAE_C directly to rdata->dmae_cmd_id please.