From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net-next] net: phy: improve struct phy_device member interrupts handling Date: Fri, 09 Nov 2018 20:12:22 -0800 (PST) Message-ID: <20181109.201222.2135261652942693940.davem@davemloft.net> References: <63a44097-c37d-eb0f-98c8-2c1fefd1f246@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37716 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728290AbeKJPOh (ORCPT ); Sat, 10 Nov 2018 10:14:37 -0500 In-Reply-To: <63a44097-c37d-eb0f-98c8-2c1fefd1f246@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:35:52 +0100 > As a heritage from the very early days of phylib member interrupts is > defined as u32 even though it's just a flag whether interrupts are > enabled. So we can change it to a bitfield member. In addition change > the code dealing with this member in a way that it's clear we're > dealing with a bool value. > > Signed-off-by: Heiner Kallweit > --- > v2: > - use false/true instead of 0/1 for the constants Applied.