From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [Patch net-next] net: dump more useful information in netdev_rx_csum_fault() Date: Fri, 09 Nov 2018 20:16:30 -0800 (PST) Message-ID: <20181109.201630.1672707103795948980.davem@davemloft.net> References: <20181109194333.19949-1-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37782 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728548AbeKJPTh (ORCPT ); Sat, 10 Nov 2018 10:19:37 -0500 In-Reply-To: <20181109194333.19949-1-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Fri, 9 Nov 2018 11:43:33 -0800 > diff --git a/net/core/datagram.c b/net/core/datagram.c > index 57f3a6fcfc1e..d8f4d55cd6c5 100644 > --- a/net/core/datagram.c > +++ b/net/core/datagram.c > @@ -736,7 +736,7 @@ __sum16 __skb_checksum_complete_head(struct sk_buff *skb, int len) > if (likely(!sum)) { > if (unlikely(skb->ip_summed == CHECKSUM_COMPLETE) && > !skb->csum_complete_sw) > - netdev_rx_csum_fault(skb->dev); > + netdev_rx_csum_fault(skb->dev, skb); > } > if (!skb_shared(skb)) > skb->csum_valid = !sum; Didn't you move this function into net/core/skbuff.c? :-) Please respin.