From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute] ss: Actually print left delimiter for columns Date: Fri, 9 Nov 2018 09:05:46 -0800 Message-ID: <20181109090546.50c15c61@xeon-e3> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Yoann P." , netdev@vger.kernel.org To: Stefano Brivio Return-path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:41932 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728198AbeKJCrQ (ORCPT ); Fri, 9 Nov 2018 21:47:16 -0500 Received: by mail-pf1-f195.google.com with SMTP id e22-v6so1188454pfn.8 for ; Fri, 09 Nov 2018 09:05:49 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 29 Oct 2018 23:04:25 +0100 Stefano Brivio wrote: > While rendering columns, we use a local variable to keep track of the > field currently being printed, without touching current_field, which is > used for buffering. > > Use the right pointer to access the left delimiter for the current column, > instead of always printing the left delimiter for the last buffered field, > which is usually an empty string. > > This fixes an issue especially visible on narrow terminals, where some > columns might be displayed without separation. > > Reported-by: YoyPa > Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table") > Signed-off-by: Stefano Brivio > Tested-by: YoyPa This test broke the testsuite/ss/ssfilter.t test. Please fix the test to match your new output format, or I will have to revert it.