From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH v5 bpf-next 0/7] bpftool: support loading flow dissector Date: Fri, 9 Nov 2018 12:15:11 -0800 Message-ID: <20181109121511.254dfd59@cakuba.netronome.com> References: <20181109162146.78019-1-sdf@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org, quentin.monnet@netronome.com, guro@fb.com, jiong.wang@netronome.com, bhole_prashant_q7@lab.ntt.co.jp, john.fastabend@gmail.com, jbenc@redhat.com, treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com, sandipan@linux.vnet.ibm.com To: Stanislav Fomichev Return-path: Received: from mail-qk1-f193.google.com ([209.85.222.193]:33434 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725883AbeKJF51 (ORCPT ); Sat, 10 Nov 2018 00:57:27 -0500 Received: by mail-qk1-f193.google.com with SMTP id o89so3849479qko.0 for ; Fri, 09 Nov 2018 12:15:19 -0800 (PST) In-Reply-To: <20181109162146.78019-1-sdf@google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 9 Nov 2018 08:21:39 -0800, Stanislav Fomichev wrote: > v5 changes: > * FILE -> PATH for load/loadall (can be either file or directory now) > * simpler implementation for __bpf_program__pin_name > * removed p_err for REQ_ARGS checks > * parse_atach_detach_args -> parse_attach_detach_args > * for -> while in bpf_object__pin_{programs,maps} recovery Thanks! Patch 3 needs attention from maintainers but the rest LGTM!