From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Monnet Subject: [PATCH bpf-next 0/9] bpf: pass device ops as callbacks and remove some ndo_bpf subcommands Date: Fri, 9 Nov 2018 13:03:23 +0000 Message-ID: <20181109130332.27576-1-quentin.monnet@netronome.com> Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Quentin Monnet To: Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-wm1-f65.google.com ([209.85.128.65]:51956 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727667AbeKIWoa (ORCPT ); Fri, 9 Nov 2018 17:44:30 -0500 Received: by mail-wm1-f65.google.com with SMTP id w7-v6so1958561wmc.1 for ; Fri, 09 Nov 2018 05:03:58 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: For passing device functions for offloaded eBPF programs, there used to be no place where to store the pointer without making the non-offloaded programs pay a memory price. As a consequence, three functions were called with ndo_bpf() through specific commands. Now that we have struct bpf_offload_dev, and since none of those operations rely on RTNL, we can turn these three commands into hooks inside the struct bpf_prog_offload_ops, and pass them as part of bpf_offload_dev_create(). This patch set changes the offload architecture to do so, and brings the relevant changes to the nfp and netdevsim drivers. Quentin Monnet (9): nfp: bpf: move nfp_bpf_analyzer_ops from verifier.c to offload.c bpf: pass a struct with offload callbacks to bpf_offload_dev_create() bpf: call verify_insn from its callback in struct bpf_offload_dev bpf: call finalize() from its callback in struct bpf_offload_dev bpf: call verifier_prep from its callback in struct bpf_offload_dev bpf: pass translate() as a callback and remove its ndo_bpf subcommand bpf: pass destroy() as a callback and remove its ndo_bpf subcommand bpf: pass prog instead of env to bpf_prog_offload_verifier_prep() bpf: do not pass netdev to translate() and prepare() offload callbacks drivers/net/ethernet/netronome/nfp/bpf/main.c | 2 +- drivers/net/ethernet/netronome/nfp/bpf/main.h | 6 +- .../net/ethernet/netronome/nfp/bpf/offload.c | 34 ++++----- .../net/ethernet/netronome/nfp/bpf/verifier.c | 11 +-- drivers/net/netdevsim/bpf.c | 51 +++++++------ include/linux/bpf.h | 8 +- include/linux/bpf_verifier.h | 2 +- include/linux/netdevice.h | 12 --- kernel/bpf/offload.c | 75 +++++++------------ kernel/bpf/verifier.c | 2 +- 10 files changed, 85 insertions(+), 118 deletions(-) -- 2.17.1