From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Subject: Re: [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate
Date: Fri, 9 Nov 2018 15:16:34 +0100 [thread overview]
Message-ID: <20181109141634.GC1364@lunn.ch> (raw)
In-Reply-To: <VI1PR0402MB28001D2F8046CE09F6EE2433E0C60@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Hi Ioana
> I will send a v2 changing the return value to -ENODEV in case no
> cpus with an affine DPIO is found.
It would be good to review all the cases where IS_ERR_OR_NULL() is
used. It is very easy to get wrong. In fact, it has been suggested
this macro is removed, because it is used wrongly way too often. Try
to avoid it if you can.
Andrew
next prev parent reply other threads:[~2018-11-09 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 13:17 [PATCH net-next 0/2] dpaa2-eth: defer probe on object allocate Ioana Ciornei
2018-11-08 13:17 ` [PATCH net-next 2/2] dpaa2-ptp: defer probe when portal allocation failed Ioana Ciornei
2018-11-08 13:17 ` [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate Ioana Ciornei
2018-11-08 18:25 ` Andrew Lunn
2018-11-09 14:01 ` Ioana Ciornei
2018-11-09 14:16 ` Andrew Lunn [this message]
2018-11-09 14:24 ` Ioana Ciornei
2018-11-09 3:28 ` [PATCH net-next 0/2] " David Miller
2018-11-09 3:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109141634.GC1364@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).