From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next 1/2] dpaa2-eth: defer probe on object allocate
Date: Fri, 9 Nov 2018 15:16:34 +0100
Message-ID: <20181109141634.GC1364@lunn.ch>
References: <1541683054-22273-1-git-send-email-ioana.ciornei@nxp.com>
 <1541683054-22273-2-git-send-email-ioana.ciornei@nxp.com>
 <20181108182507.GC5259@lunn.ch>
 <VI1PR0402MB28001D2F8046CE09F6EE2433E0C60@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:56864 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727735AbeKIX5Y (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 9 Nov 2018 18:57:24 -0500
Content-Disposition: inline
In-Reply-To: <VI1PR0402MB28001D2F8046CE09F6EE2433E0C60@VI1PR0402MB2800.eurprd04.prod.outlook.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Ioana

> I will send a v2 changing the return value to -ENODEV in case no
> cpus with an affine DPIO is found.

It would be good to review all the cases where IS_ERR_OR_NULL() is
used. It is very easy to get wrong. In fact, it has been suggested
this macro is removed, because it is used wrongly way too often. Try
to avoid it if you can.

   Andrew