From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanislav Fomichev Subject: Re: [PATCH v4 bpf-next 2/7] libbpf: cleanup after partial failure in bpf_object__pin Date: Fri, 9 Nov 2018 07:41:55 -0800 Message-ID: <20181109154155.m2zqdylynsk4w4qy@mini-arch> References: <20181109002213.5914-1-s@fomichev.me> <20181109002213.5914-3-s@fomichev.me> <20181108193705.2933c2bc@cakuba.netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, shuah@kernel.org, quentin.monnet@netronome.com, guro@fb.com, jiong.wang@netronome.com, sdf@google.com, bhole_prashant_q7@lab.ntt.co.jp, john.fastabend@gmail.com, jbenc@redhat.com, treeze.taeung@gmail.com, yhs@fb.com, osk@fb.com, sandipan@linux.vnet.ibm.com To: Jakub Kicinski Return-path: Received: from mail-pl1-f195.google.com ([209.85.214.195]:32775 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbeKJBXD (ORCPT ); Fri, 9 Nov 2018 20:23:03 -0500 Received: by mail-pl1-f195.google.com with SMTP id w22-v6so1116573plk.0 for ; Fri, 09 Nov 2018 07:41:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <20181108193705.2933c2bc@cakuba.netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On 11/08, Jakub Kicinski wrote: > On Thu, 8 Nov 2018 16:22:08 -0800, Stanislav Fomichev wrote: > > + for (map = bpf_map__prev(map, obj); > > + map != NULL; > > + map = bpf_map__prev(map, obj)) { > > nit pick: if you need to respin all these for loops on error paths could > have been more concise while loops Agreed with everything, will address this one and the other comments in v5. Thank you for another thorough review!