From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrey Ignatov Subject: Re: [PATCH bpf-next 2/4] bpf: Split bpf_sk_lookup Date: Fri, 9 Nov 2018 17:30:36 +0000 Message-ID: <20181109173034.GA61534@rdna-mbp.dhcp.thefacebook.com> References: <497a6a47655e647ef51d127b4d5ca2cea0d1d268.1541695683.git.rdna@fb.com> <20181109171928.jb7k2lbe2rdncyet@kafai-mbp.dhcp.thefacebook.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "joe@wand.net.nz" , Kernel Team To: Martin Lau Return-path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:43862 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727961AbeKJDNH (ORCPT ); Fri, 9 Nov 2018 22:13:07 -0500 In-Reply-To: <20181109171928.jb7k2lbe2rdncyet@kafai-mbp.dhcp.thefacebook.com> Content-Language: en-US Content-ID: Sender: netdev-owner@vger.kernel.org List-ID: TWFydGluIExhdSA8a2FmYWlAZmIuY29tPiBbRnJpLCAyMDE4LTExLTA5IDA5OjE5IC0wODAwXToN Cj4gT24gVGh1LCBOb3YgMDgsIDIwMTggYXQgMDg6NTQ6MjNBTSAtMDgwMCwgQW5kcmV5IElnbmF0 b3Ygd3JvdGU6DQo+ID4gU3BsaXQgYnBmX3NrX2xvb2t1cCB0byBzZXBhcmF0ZSBjb3JlIGZ1bmN0 aW9uYWxpdHksIHRoYXQgY2FuIGJlIHJldXNlZA0KPiA+IHRvIG1ha2Ugc29ja2V0IGxvb2t1cCBh dmFpbGFibGUgdG8gbW9yZSBwcm9ncmFtIHR5cGVzLCBmcm9tDQo+ID4gZnVuY3Rpb25hbGl0eSBz cGVjaWZpYyB0byBwcm9ncmFtIHR5cGVzIHRoYXQgaGF2ZSBhY2Nlc3MgdG8gc2tiLg0KPiA+IA0K PiA+IENvcmUgZnVuY3Rpb25hbGl0eSBpcyBwbGFjZWQgdG8gX19icGZfc2tfbG9va3VwLiBBbmQg YnBmX3NrX2xvb2t1cCBvbmx5DQo+ID4gZ2V0cyBjYWxsZXIgbmV0bnMgYW5kIGlmaW5kZXggZnJv bSBza2IgYW5kIHBhc3NlcyBpdCB0byBfX2JwZl9za19sb29rdXAuDQo+ID4gDQo+ID4gUHJvZ3Jh bSB0eXBlcyB0aGF0IGRvbid0IGhhdmUgYWNjZXNzIHRvIHNrYiBjYW4ganVzdCBwYXNzIE5VTEwg dG8NCj4gPiBfX2JwZl9za19sb29rdXAgdGhhdCB3aWxsIGJlIGhhbmRsZWQgY29ycmVjdGx5IGJ5 IGJvdGggaW5ldHssNn1fc2RpZiBhbmQNCj4gPiBsb29rdXAgZnVuY3Rpb25zLg0KPiA+IA0KPiA+ IFRoaXMgaXMgcmVmYWN0b3JpbmcgdGhhdCBzaW1wbHkgbW92ZXMgYmxvY2tzIGFyb3VuZCBhbmQg ZG9lcyBOT1QgY2hhbmdlDQo+ID4gZXhpc3RpbmcgbG9naWMuDQo+ID4gDQo+ID4gU2lnbmVkLW9m Zi1ieTogQW5kcmV5IElnbmF0b3YgPHJkbmFAZmIuY29tPg0KPiA+IEFja2VkLWJ5OiBBbGV4ZWkg U3Rhcm92b2l0b3YgPGFzdEBrZXJuZWwub3JnPg0KPiA+IC0tLQ0KPiA+ICBuZXQvY29yZS9maWx0 ZXIuYyB8IDM4ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tDQo+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkNCj4gPiANCj4g PiBkaWZmIC0tZ2l0IGEvbmV0L2NvcmUvZmlsdGVyLmMgYi9uZXQvY29yZS9maWx0ZXIuYw0KPiA+ IGluZGV4IDlhMTMyN2ViMjVmYS4uZGMwZjg2YTcwN2I3IDEwMDY0NA0KPiA+IC0tLSBhL25ldC9j b3JlL2ZpbHRlci5jDQo+ID4gKysrIGIvbmV0L2NvcmUvZmlsdGVyLmMNCj4gPiBAQCAtNDgyNSwx NCArNDgyNSwxMCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGJwZl9mdW5jX3Byb3RvIGJwZl9sd3Rf c2VnNl9hZGp1c3Rfc3JoX3Byb3RvID0gew0KPiA+ICANCj4gPiAgI2lmZGVmIENPTkZJR19JTkVU DQo+ID4gIHN0YXRpYyBzdHJ1Y3Qgc29jayAqc2tfbG9va3VwKHN0cnVjdCBuZXQgKm5ldCwgc3Ry dWN0IGJwZl9zb2NrX3R1cGxlICp0dXBsZSwNCj4gPiAtCQkJICAgICAgc3RydWN0IHNrX2J1ZmYg KnNrYiwgdTggZmFtaWx5LCB1OCBwcm90bykNCj4gPiArCQkJICAgICAgc3RydWN0IHNrX2J1ZmYg KnNrYiwgdTggZmFtaWx5LCB1OCBwcm90bywgaW50IGRpZikNCj4gPiAgew0KPiA+ICAJYm9vbCBy ZWZjb3VudGVkID0gZmFsc2U7DQo+ID4gIAlzdHJ1Y3Qgc29jayAqc2sgPSBOVUxMOw0KPiA+IC0J aW50IGRpZiA9IDA7DQo+ID4gLQ0KPiA+IC0JaWYgKHNrYi0+ZGV2KQ0KPiA+IC0JCWRpZiA9IHNr Yi0+ZGV2LT5pZmluZGV4Ow0KPiA+ICANCj4gPiAgCWlmIChmYW1pbHkgPT0gQUZfSU5FVCkgew0K PiA+ICAJCV9fYmUzMiBzcmM0ID0gdHVwbGUtPmlwdjQuc2FkZHI7DQo+ID4gQEAgLTQ4NzUsMTYg KzQ4NzEsMTYgQEAgc3RhdGljIHN0cnVjdCBzb2NrICpza19sb29rdXAoc3RydWN0IG5ldCAqbmV0 LCBzdHJ1Y3QgYnBmX3NvY2tfdHVwbGUgKnR1cGxlLA0KPiA+ICAJcmV0dXJuIHNrOw0KPiA+ICB9 DQo+ID4gIA0KPiA+IC0vKiBicGZfc2tfbG9va3VwIHBlcmZvcm1zIHRoZSBjb3JlIGxvb2t1cCBm b3IgZGlmZmVyZW50IHR5cGVzIG9mIHNvY2tldHMsDQo+ID4gKy8qIF9fYnBmX3NrX2xvb2t1cCBw ZXJmb3JtcyB0aGUgY29yZSBsb29rdXAgZm9yIGRpZmZlcmVudCB0eXBlcyBvZiBzb2NrZXRzLA0K PiA+ICAgKiB0YWtpbmcgYSByZWZlcmVuY2Ugb24gdGhlIHNvY2tldCBpZiBpdCBkb2Vzbid0IGhh dmUgdGhlIGZsYWcgU09DS19SQ1VfRlJFRS4NCj4gPiAgICogUmV0dXJucyB0aGUgc29ja2V0IGFz IGFuICd1bnNpZ25lZCBsb25nJyB0byBzaW1wbGlmeSB0aGUgY2FzdGluZyBpbiB0aGUNCj4gPiAg ICogY2FsbGVycyB0byBzYXRpc2Z5IEJQRl9DQUxMIGRlY2xhcmF0aW9ucy4NCj4gPiAgICovDQo+ ID4gIHN0YXRpYyB1bnNpZ25lZCBsb25nDQo+ID4gLWJwZl9za19sb29rdXAoc3RydWN0IHNrX2J1 ZmYgKnNrYiwgc3RydWN0IGJwZl9zb2NrX3R1cGxlICp0dXBsZSwgdTMyIGxlbiwNCj4gPiAtCSAg ICAgIHU4IHByb3RvLCB1NjQgbmV0bnNfaWQsIHU2NCBmbGFncykNCj4gPiArX19icGZfc2tfbG9v a3VwKHN0cnVjdCBza19idWZmICpza2IsIHN0cnVjdCBicGZfc29ja190dXBsZSAqdHVwbGUsIHUz MiBsZW4sDQo+ID4gKwkJdTggcHJvdG8sIHU2NCBuZXRuc19pZCwgc3RydWN0IG5ldCAqY2FsbGVy X25ldCwgaW50IGlmaW5kZXgsDQo+ID4gKwkJdTY0IGZsYWdzKQ0KPiBUaGF0IGxvb2tzIGEgYml0 IGRpZmZlcmVudCBmcm9tIHRoZSBvbmUgbGFuZGVkIHRvIGJwZi1uZXh0Lg0KPiBZb3UgbWF5IG5l ZWQgdG8gcmVzcGluIHRoZSBzZXQuDQoNClNpbmNlIE5pdGluJ3MgdmVyc2lvbiBpcyBsYW5kZWQg bm93LCBJJ2xsIHJlYmFzZSBvbiB0b3Agb2YgaXQgYW5kIHRoaXMNCnBhdGNoIGp1c3Qgd29uJ3Qg YmUgbmVlZGVkIChpbml0aWFsbHkgSSBkaWQgaXQgdG8gdW5ibG9jayBteXNlbGYpLg0KDQpJJ2xs IGFsc28gYWRkcmVzcyB0aGUgbml0IGluIHBhdGNoIDMgYW5kIHNlbmQgdjIgd2l0aCBib3RoIGNo YW5nZXMuDQoNClRoYW5rcyBNYXJ0aW4hDQoNCj4gPiAgew0KPiA+IC0Jc3RydWN0IG5ldCAqY2Fs bGVyX25ldDsNCj4gPiAgCXN0cnVjdCBzb2NrICpzayA9IE5VTEw7DQo+ID4gIAl1OCBmYW1pbHkg PSBBRl9VTlNQRUM7DQo+ID4gIAlzdHJ1Y3QgbmV0ICpuZXQ7DQo+ID4gQEAgLTQ4OTMsMTkgKzQ4 ODksMTUgQEAgYnBmX3NrX2xvb2t1cChzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCBzdHJ1Y3QgYnBmX3Nv Y2tfdHVwbGUgKnR1cGxlLCB1MzIgbGVuLA0KPiA+ICAJaWYgKHVubGlrZWx5KGZhbWlseSA9PSBB Rl9VTlNQRUMgfHwgbmV0bnNfaWQgPiBVMzJfTUFYIHx8IGZsYWdzKSkNCj4gPiAgCQlnb3RvIG91 dDsNCj4gPiAgDQo+ID4gLQlpZiAoc2tiLT5kZXYpDQo+ID4gLQkJY2FsbGVyX25ldCA9IGRldl9u ZXQoc2tiLT5kZXYpOw0KPiA+IC0JZWxzZQ0KPiA+IC0JCWNhbGxlcl9uZXQgPSBzb2NrX25ldChz a2ItPnNrKTsNCj4gPiAgCWlmIChuZXRuc19pZCkgew0KPiA+ICAJCW5ldCA9IGdldF9uZXRfbnNf YnlfaWQoY2FsbGVyX25ldCwgbmV0bnNfaWQpOw0KPiA+ICAJCWlmICh1bmxpa2VseSghbmV0KSkN Cj4gPiAgCQkJZ290byBvdXQ7DQo+ID4gLQkJc2sgPSBza19sb29rdXAobmV0LCB0dXBsZSwgc2ti LCBmYW1pbHksIHByb3RvKTsNCj4gPiArCQlzayA9IHNrX2xvb2t1cChuZXQsIHR1cGxlLCBza2Is IGZhbWlseSwgcHJvdG8sIGlmaW5kZXgpOw0KPiA+ICAJCXB1dF9uZXQobmV0KTsNCj4gPiAgCX0g ZWxzZSB7DQo+ID4gIAkJbmV0ID0gY2FsbGVyX25ldDsNCj4gPiAtCQlzayA9IHNrX2xvb2t1cChu ZXQsIHR1cGxlLCBza2IsIGZhbWlseSwgcHJvdG8pOw0KPiA+ICsJCXNrID0gc2tfbG9va3VwKG5l dCwgdHVwbGUsIHNrYiwgZmFtaWx5LCBwcm90bywgaWZpbmRleCk7DQo+ID4gIAl9DQo+ID4gIA0K PiA+ICAJaWYgKHNrKQ0KPiA+IEBAIC00OTE0LDYgKzQ5MDYsMjIgQEAgYnBmX3NrX2xvb2t1cChz dHJ1Y3Qgc2tfYnVmZiAqc2tiLCBzdHJ1Y3QgYnBmX3NvY2tfdHVwbGUgKnR1cGxlLCB1MzIgbGVu LA0KPiA+ICAJcmV0dXJuICh1bnNpZ25lZCBsb25nKSBzazsNCj4gPiAgfQ0KPiA+ICANCj4gPiAr c3RhdGljIHVuc2lnbmVkIGxvbmcNCj4gPiArYnBmX3NrX2xvb2t1cChzdHJ1Y3Qgc2tfYnVmZiAq c2tiLCBzdHJ1Y3QgYnBmX3NvY2tfdHVwbGUgKnR1cGxlLCB1MzIgbGVuLA0KPiA+ICsJICAgICAg dTggcHJvdG8sIHU2NCBuZXRuc19pZCwgdTY0IGZsYWdzKQ0KPiA+ICt7DQo+ID4gKwlzdHJ1Y3Qg bmV0ICpjYWxsZXJfbmV0ID0gc29ja19uZXQoc2tiLT5zayk7DQo+ID4gKwlpbnQgaWZpbmRleCA9 IDA7DQo+ID4gKw0KPiA+ICsJaWYgKHNrYi0+ZGV2KSB7DQo+ID4gKwkJY2FsbGVyX25ldCA9IGRl dl9uZXQoc2tiLT5kZXYpOw0KPiA+ICsJCWlmaW5kZXggPSBza2ItPmRldi0+aWZpbmRleDsNCj4g PiArCX0NCj4gPiArDQo+ID4gKwlyZXR1cm4gX19icGZfc2tfbG9va3VwKHNrYiwgdHVwbGUsIGxl biwgcHJvdG8sIG5ldG5zX2lkLCBjYWxsZXJfbmV0LA0KPiA+ICsJCQkgICAgICAgaWZpbmRleCwg ZmxhZ3MpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICBCUEZfQ0FMTF81KGJwZl9za19sb29rdXBfdGNw LCBzdHJ1Y3Qgc2tfYnVmZiAqLCBza2IsDQo+ID4gIAkgICBzdHJ1Y3QgYnBmX3NvY2tfdHVwbGUg KiwgdHVwbGUsIHUzMiwgbGVuLCB1NjQsIG5ldG5zX2lkLCB1NjQsIGZsYWdzKQ0KPiA+ICB7DQo+ ID4gLS0gDQo+ID4gMi4xNy4xDQo+ID4gDQoNCi0tIA0KQW5kcmV5IElnbmF0b3YNCg==