From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH iproute] ss: Actually print left delimiter for columns Date: Fri, 9 Nov 2018 20:47:05 +0100 Message-ID: <20181109204705.270d68bb@redhat.com> References: <20181109090546.50c15c61@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "Yoann P." , netdev@vger.kernel.org, Phil Sutter To: Stephen Hemminger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40326 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbeKJF3O (ORCPT ); Sat, 10 Nov 2018 00:29:14 -0500 In-Reply-To: <20181109090546.50c15c61@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 9 Nov 2018 09:05:46 -0800 Stephen Hemminger wrote: > On Mon, 29 Oct 2018 23:04:25 +0100 > Stefano Brivio wrote: > > > While rendering columns, we use a local variable to keep track of the > > field currently being printed, without touching current_field, which is > > used for buffering. > > > > Use the right pointer to access the left delimiter for the current column, > > instead of always printing the left delimiter for the last buffered field, > > which is usually an empty string. > > > > This fixes an issue especially visible on narrow terminals, where some > > columns might be displayed without separation. > > > > Reported-by: YoyPa > > Fixes: 691bd854bf4a ("ss: Buffer raw fields first, then render them as a table") > > Signed-off-by: Stefano Brivio > > Tested-by: YoyPa > > This test broke the testsuite/ss/ssfilter.t test. > Please fix the test to match your new output format, or I will have to revert it. Ouch, sorry, I didn't notice that "new" test. I'll fix that by tomorrow. -- Stefano