From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: David Miller <davem@davemloft.net>
Cc: oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: sched: cls_flower: validate nested enc_opts_policy to avoid build warning
Date: Fri, 9 Nov 2018 20:58:12 -0800 [thread overview]
Message-ID: <20181109205812.019637e2@cakuba.netronome.com> (raw)
In-Reply-To: <20181109.204025.1856075959976079971.davem@davemloft.net>
On Fri, 09 Nov 2018 20:40:25 -0800 (PST), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@netronome.com>
> Date: Fri, 9 Nov 2018 14:41:22 -0800
>
> > TCA_FLOWER_KEY_ENC_OPTS and TCA_FLOWER_KEY_ENC_OPTS_MASK can only
> > currently contain further nested attributes, which are parsed by
> > hand, so the policy is never actually used. Add the validation
> > anyway to avoid potential bugs when other attributes are added
> > and to make the attribute structure slightly more clear. Validation
> > will also set extact to point to bad attribute on error.
> >
> > Fixes: 0a6e77784f49 ("net/sched: allow flower to match tunnel options")
> > Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> > Acked-by: Simon Horman <simon.horman@netronome.com>
>
> If this fixes a build warning, please include the build warning
> message in your commit log.
>
> Thanks!
Ah, sorry, it's a W=1 warning, which should have been mentioned, too.
I'll repost shortly!
prev parent reply other threads:[~2018-11-10 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 22:41 [PATCH net] net: sched: cls_flower: validate nested enc_opts_policy to avoid build warning Jakub Kicinski
2018-11-10 4:40 ` David Miller
2018-11-10 4:58 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109205812.019637e2@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox