From: Andrew Lunn <andrew@lunn.ch>
To: Salil Mehta <salil.mehta@huawei.com>
Cc: davem@davemloft.net, yuvalm@mellanox.com, leon@kernel.org,
yisen.zhuang@huawei.com, lipeng321@huawei.com,
mehta.salil@opnsrc.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [RFC PATCH 00/10] net: hns3: Adds support of debugfs to HNS3 driver
Date: Fri, 9 Nov 2018 23:43:46 +0100 [thread overview]
Message-ID: <20181109224346.GD5259@lunn.ch> (raw)
In-Reply-To: <20181109220743.10264-1-salil.mehta@huawei.com>
> 3. Debugfs looks more unstructured unlike sysfs. Is there any
> de-facto standard of the user-api or drivers are allowed to
> use it in any way to expose the information from kernel.
Hi Salil
You don't really have a user api using debugfs, because debugfs is
unstable. Anything can change at any time. Any user tools which use
debugfs can be expected to break at any time as the information in
debugfs changes. debugfs is for debug, not to export an API. And in
production systems, it is often not mounted.
As much as possible, you are recommended to use existing APIs,
ethtool, devlink, etc.
Andrew
next prev parent reply other threads:[~2018-11-09 22:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 22:07 [RFC PATCH 00/10] net: hns3: Adds support of debugfs to HNS3 driver Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 01/10] net: hns3: Add debugfs framework registration Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 02/10] net: hns3: Add "queue info" query function Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 03/10] net: hns3: Add "FD flow table" info " Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 04/10] net: hns3: Add "promisc mode" config " Salil Mehta
2018-11-09 22:49 ` Andrew Lunn
2018-11-11 16:45 ` Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 05/10] net: hns3: Add "tc config" " Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 06/10] net: hns3: Add "tm " Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 07/10] net: hns3: Add checksum " Salil Mehta
2018-11-09 22:51 ` Andrew Lunn
2018-11-11 16:23 ` Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 08/10] net: hns3: Add PFC config " Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 09/10] net: hns3: Add "qos prio map" " Salil Mehta
2018-11-09 22:07 ` [RFC PATCH 10/10] net: hns3: Add "qos buffer" config " Salil Mehta
2018-11-09 22:43 ` Andrew Lunn [this message]
2018-11-11 15:12 ` [RFC PATCH 00/10] net: hns3: Adds support of debugfs to HNS3 driver Salil Mehta
2018-11-11 16:18 ` Andrew Lunn
2018-11-11 16:47 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109224346.GD5259@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lipeng321@huawei.com \
--cc=mehta.salil@opnsrc.net \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).