Re: [PATCH v2] net: phy: leds: Don't make our own link speed names

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2041 bytes --]

Hi Kyle,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Kyle-Roeschley/net-phy-leds-Don-t-make-our-own-link-speed-names/20181109-143344
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

>> drivers/net/phy/phy_led_triggers.c:82:53: warning: incorrect type in argument 4 (different modifiers)
   drivers/net/phy/phy_led_triggers.c:82:53:    expected char *suffix
   drivers/net/phy/phy_led_triggers.c:82:53:    got char const *
   drivers/net/phy/phy_led_triggers.c: In function 'phy_led_trigger_register':
   drivers/net/phy/phy_led_triggers.c:82:9: warning: passing argument 4 of 'phy_led_trigger_format_name' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
            phy_speed_to_str(speed));
            ^~~~~~~~~~~~~~~~
   drivers/net/phy/phy_led_triggers.c:69:13: note: expected 'char *' but argument is of type 'const char *'
    static void phy_led_trigger_format_name(struct phy_device *phy, char *buf,
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +82 drivers/net/phy/phy_led_triggers.c

    75	
    76	static int phy_led_trigger_register(struct phy_device *phy,
    77					    struct phy_led_trigger *plt,
    78					    unsigned int speed)
    79	{
    80		plt->speed = speed;
    81		phy_led_trigger_format_name(phy, plt->name, sizeof(plt->name),
  > 82					    phy_speed_to_str(speed));
    83		plt->trigger.name = plt->name;
    84	
    85		return led_trigger_register(&plt->trigger);
    86	}
    87	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66569 bytes --]