From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v3 0/2] net: phy: replace PHY_HAS_INTERRUPT with a check for config_intr and ack_interrupt Date: Sun, 11 Nov 2018 09:38:03 -0800 (PST) Message-ID: <20181111.093803.1220111720420778659.davem@davemloft.net> References: <203c4d9e-f39a-7a08-46c3-4ee6e61f181e@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com, carlo@caione.org, khilman@baylibre.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org To: hkallweit1@gmail.com Return-path: In-Reply-To: <203c4d9e-f39a-7a08-46c3-4ee6e61f181e@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Heiner Kallweit Date: Fri, 9 Nov 2018 18:15:31 +0100 > Flag PHY_HAS_INTERRUPT is used only here for this small check. I think > using interrupts isn't possible if a driver defines neither > config_intr nor ack_interrupts callback. So we can replace checking > flag PHY_HAS_INTERRUPT with checking for these callbacks. > This allows to remove this flag from all driver configs. > > v2: > - add helper for check in patch 1 > - remove PHY_HAS_INTERRUPT from all drivers, not only Realtek > - remove flag PHY_HAS_INTERRUPT completely > > v3: > - rebase patch 2 Series applied, but please sort out that one driver which is preventing us requiring both config_intr && ack_interrupt. Thanks.