From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch net] net: dsa: mv88e6xxx: Fix clearing of stats counters Date: Sun, 11 Nov 2018 10:19:46 -0800 (PST) Message-ID: <20181111.101946.1277467336762690397.davem@davemloft.net> References: <1541893270-4442-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: andrew@lunn.ch Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37836 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729314AbeKLEJB (ORCPT ); Sun, 11 Nov 2018 23:09:01 -0500 In-Reply-To: <1541893270-4442-1-git-send-email-andrew@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: From: Andrew Lunn Date: Sun, 11 Nov 2018 00:41:10 +0100 > The mv88e6161 would sometime fail to probe with a timeout waiting for > the switch to complete an operation. This operation is supposed to > clear the statistics counters. However, due to a read/modify/write, > without the needed mask, the operation actually carried out was more > random, with invalid parameters, resulting in the switch not > responding. We need to preserve the histogram mode bits, so apply a > mask to keep them. > > Reported-by: Chris Healy > Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode") > Signed-off-by: Andrew Lunn Oops. Applied and queued up for -stable.