From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2 Date: Sun, 11 Nov 2018 10:20:31 -0800 (PST) Message-ID: <20181111.102031.85169421097705193.davem@davemloft.net> References: <1541893839-4828-1-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: andrew@lunn.ch Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:37846 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729397AbeKLEJp (ORCPT ); Sun, 11 Nov 2018 23:09:45 -0500 In-Reply-To: <1541893839-4828-1-git-send-email-andrew@lunn.ch> Sender: netdev-owner@vger.kernel.org List-ID: From: Andrew Lunn Date: Sun, 11 Nov 2018 00:50:39 +0100 > We already have a workaround for a couple of switches whose internal > PHYs only have the Marvel OUI, but no model number. We detect such > PHYs and give them the 6390 ID as the model number. However the > mv88e6161 has two SERDES interfaces in the same address range as its > internal PHYs. These suffer from the same problem, the Marvell OUI, > but no model number. As a result, these SERDES interfaces were getting > the same PHY ID as the mv88e6390, even though they are not PHYs, and > the Marvell PHY driver was trying to drive them. > > Add a special case to stop this happen. > > Reported-by: Chris Healy > Signed-off-by: Andrew Lunn Please address Sergei's feedback, thank you.