From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net 4/4] qed: Fix reading wrong value in loop condition
Date: Sun, 11 Nov 2018 10:26:43 -0800 (PST)
Message-ID: <20181111.102643.1735923349642608264.davem@davemloft.net>
References: <20181111150500.4345-1-denis.bolotin@cavium.com>
        <20181111150500.4345-5-denis.bolotin@cavium.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, michal.kalderon@cavium.com,
        ariel.elior@cavium.com
To: denis.bolotin@cavium.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:37990 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726283AbeKLEP6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 11 Nov 2018 23:15:58 -0500
In-Reply-To: <20181111150500.4345-5-denis.bolotin@cavium.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Denis Bolotin <denis.bolotin@cavium.com>
Date: Sun, 11 Nov 2018 17:05:00 +0200

> diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
> index 0f0aba7..aa7504a 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_int.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
> @@ -992,6 +992,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
>  	 */
>  	do {
>  		index = p_sb_attn->sb_index;
> +		/* finish reading index before the loop condition */
> +		rmb();

Please use dma_rmb().