From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Subject: Re: [PATCH iproute2] testsuite: ss: Fix spacing in expected output for ssfilter.t Date: Sun, 11 Nov 2018 13:12:15 +0100 Message-ID: <20181111121214.GM6440@orbyte.nwl.cc> References: <20181110214844.GL6440@orbyte.nwl.cc> <20181111125039.639dd608@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Hemminger , "Yoann P." , netdev@vger.kernel.org To: Stefano Brivio Return-path: Received: from orbyte.nwl.cc ([151.80.46.58]:37252 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727467AbeKKWAm (ORCPT ); Sun, 11 Nov 2018 17:00:42 -0500 Content-Disposition: inline In-Reply-To: <20181111125039.639dd608@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Stefano, On Sun, Nov 11, 2018 at 12:50:39PM +0100, Stefano Brivio wrote: > On Sat, 10 Nov 2018 22:48:44 +0100 > Phil Sutter wrote: > > > On Sat, Nov 10, 2018 at 10:21:59AM +0100, Stefano Brivio wrote: > > > > > @@ -12,37 +12,37 @@ export TCPDIAG_FILE="$(dirname $0)/ss1.dump" > > > ts_log "[Testing ssfilter]" > > > > > > ts_ss "$0" "Match dport = 22" -Htna dport = 22 > > > -test_on "ESTAB 0 0 10.0.0.1:36266 10.0.0.1:22" > > > +test_on "ESTAB 0 0 10.0.0.1:36266 10.0.0.1:22" > > > > How about using a regular expression ('test_on' calls grep with '-E')? > > E.g. this instead of the above: > > > > | test_on "ESTAB *0 *0 *10.0.0.1:36266 *10.0.0.1:22" > > I also thought about something similar (perhaps uglier: piping the > output through tr -s ' ' in ts_ss()). > > But then I thought we might like to use this test to also check that we > don't accidentally modify spacing, so I'd rather leave it as it is, > with this patch on top. Fair enough, no objections from my side. Thanks, Phil