From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 02/17] net: sched: protect block state with
 spinlock
Date: Mon, 12 Nov 2018 09:28:59 -0800 (PST)
Message-ID: <20181112.092859.498970939054805019.davem@davemloft.net>
References: <1542009346-23780-1-git-send-email-vladbu@mellanox.com>
        <1542009346-23780-3-git-send-email-vladbu@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
        jiri@resnulli.us, ast@kernel.org, daniel@iogearbox.net
To: vladbu@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:57420 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727354AbeKMDXM (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 12 Nov 2018 22:23:12 -0500
In-Reply-To: <1542009346-23780-3-git-send-email-vladbu@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Vlad Buslov <vladbu@mellanox.com>
Date: Mon, 12 Nov 2018 09:55:31 +0200

> +#define ASSERT_BLOCK_LOCKED(block)					\
> +	WARN_ONCE(!spin_is_locked(&(block)->lock),		\
> +		  "BLOCK: assertion failed at %s (%d)\n", __FILE__,  __LINE__)

spin_is_locked() is not usable for assertions.

When SMP=n and DEBUG_SPINLOCK=n, it always returns zero.