From: Denis Bolotin <denis.bolotin@cavium.com>
To: <davem@davemloft.net>, <netdev@vger.kernel.org>
Cc: <michal.kalderon@cavium.com>, <ariel.elior@cavium.com>,
Denis Bolotin <denis.bolotin@cavium.com>
Subject: [PATCH net v2 4/4] qed: Fix reading wrong value in loop condition
Date: Mon, 12 Nov 2018 12:50:23 +0200 [thread overview]
Message-ID: <20181112105023.23842-5-denis.bolotin@cavium.com> (raw)
In-Reply-To: <20181112105023.23842-1-denis.bolotin@cavium.com>
The value of "sb_index" is written by the hardware. Reading its value and
writing it to "index" must finish before checking the loop condition.
Signed-off-by: Denis Bolotin <denis.bolotin@cavium.com>
Signed-off-by: Michal Kalderon <michal.kalderon@cavium.com>
---
drivers/net/ethernet/qlogic/qed/qed_int.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_int.c b/drivers/net/ethernet/qlogic/qed/qed_int.c
index 0f0aba7..b22f464 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_int.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_int.c
@@ -992,6 +992,8 @@ static int qed_int_attentions(struct qed_hwfn *p_hwfn)
*/
do {
index = p_sb_attn->sb_index;
+ /* finish reading index before the loop condition */
+ dma_rmb();
attn_bits = le32_to_cpu(p_sb_attn->atten_bits);
attn_acks = le32_to_cpu(p_sb_attn->atten_ack);
} while (index != p_sb_attn->sb_index);
--
1.8.3.1
next prev parent reply other threads:[~2018-11-12 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 10:50 [PATCH net v2 0/4] qed: Miscellaneous bug fixes Denis Bolotin
2018-11-12 10:50 ` [PATCH net v2 1/4] qed: Fix PTT leak in qed_drain() Denis Bolotin
2018-11-12 10:50 ` [PATCH net v2 2/4] qed: Fix overriding offload_tc by protocols without APP TLV Denis Bolotin
2018-11-12 10:50 ` [PATCH net v2 3/4] qed: Fix rdma_info structure allocation Denis Bolotin
2018-11-12 10:50 ` Denis Bolotin [this message]
2018-11-13 16:51 ` [PATCH net v2 0/4] qed: Miscellaneous bug fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112105023.23842-5-denis.bolotin@cavium.com \
--to=denis.bolotin@cavium.com \
--cc=ariel.elior@cavium.com \
--cc=davem@davemloft.net \
--cc=michal.kalderon@cavium.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox