From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [PATCH bpf-next v2] bpftool: make libbfd optional Date: Mon, 12 Nov 2018 14:02:20 -0800 Message-ID: <20181112140220.637103db@cakuba.netronome.com> References: <20181112214410.14270-1-sdf@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, quentin.monnet@netronome.com, Jiong Wang To: Stanislav Fomichev Return-path: Received: from mail-qk1-f173.google.com ([209.85.222.173]:43461 "EHLO mail-qk1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbeKMH5a (ORCPT ); Tue, 13 Nov 2018 02:57:30 -0500 Received: by mail-qk1-f173.google.com with SMTP id r71so16111150qkr.10 for ; Mon, 12 Nov 2018 14:02:25 -0800 (PST) In-Reply-To: <20181112214410.14270-1-sdf@google.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 12 Nov 2018 13:44:10 -0800, Stanislav Fomichev wrote: > Make it possible to build bpftool without libbfd. libbfd and libopcodes are > typically provided in dev/dbg packages (binutils-dev in debian) which we > usually don't have installed on the fleet machines and we'd like a way to have > bpftool version that works without installing any additional packages. > This excludes support for disassembling jit-ted code and prints an error if > the user tries to use these features. > > Tested by: > cat > FEATURES_DUMP.bpftool < feature-libbfd=0 > feature-disassembler-four-args=1 > feature-reallocarray=0 > feature-libelf=1 > feature-libelf-mmap=1 > feature-bpf=1 > EOF > FEATURES_DUMP=$PWD/FEATURES_DUMP.bpftool make > ldd bpftool | grep libbfd > > Signed-off-by: Stanislav Fomichev Seems reasonable, thanks! Acked-by: Jakub Kicinski