From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: phy: icplus: add config_intr callback
Date: Mon, 12 Nov 2018 18:34:43 +0100
Message-ID: <20181112173443.GE5075@lunn.ch>
References: <31282778-9e55-0f2e-da60-aea11a8c1182@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:59915 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727247AbeKMD3A (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 12 Nov 2018 22:29:00 -0500
Content-Disposition: inline
In-Reply-To: <31282778-9e55-0f2e-da60-aea11a8c1182@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sun, Nov 11, 2018 at 09:49:12PM +0100, Heiner Kallweit wrote:
> Move IRQ configuration for IP101A/G from config_init to config_intr
> callback. Reasons:
> 
> 1. This allows phylib to disable interrupts if needed.
> 2. Icplus was the only driver supporting interrupts w/o defining a
>    config_intr callback. Now we can add a phylib plausibility check
>    disabling interrupt mode if one of the two irq-related callbacks
>    isn't defined.
> 
> I don't own hardware with this PHY, and the change is based on the
> datasheet for IP101A LF (which is supposed to be register-compatible
> with IP101A/G). Change is compile-tested only.

Hi Heiner

This looks sensible. Thanks for fixing up this driver.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew