From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nathan Chancellor <natechancellor@gmail.com>
Subject: Re: [PATCH] geneve: Add missing braces in addr6 initializer
Date: Mon, 12 Nov 2018 15:20:13 -0700
Message-ID: <20181112222013.GA12856@flashbox>
References: <20181112221248.11477-1-natechancellor@gmail.com>
 <20181112231917.4f2f07b5@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "David S. Miller" <davem@davemloft.net>,
        Sabrina Dubroca <sd@queasysnail.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: Stefano Brivio <sbrivio@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20181112231917.4f2f07b5@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Mon, Nov 12, 2018 at 11:19:17PM +0100, Stefano Brivio wrote:
> On Mon, 12 Nov 2018 15:12:48 -0700
> Nathan Chancellor <natechancellor@gmail.com> wrote:
> 
> > Clang warns:
> > 
> > drivers/net/geneve.c:428:29: error: suggest braces around initialization
> > of subobject [-Werror,-Wmissing-braces]
> >                 struct in6_addr addr6 = { 0 };
> >                                           ^
> >                                           {}
> > 
> > Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> 
> Thanks for spotting this. By the way, I guess you should indicate in
> the subject when patches are meant for net-next.
> 

Sure, I'll be better about that in the future.

> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
> 

Thank you for the review!
Nathan

> -- 
> Stefano