From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net-next v2] geneve: Use empty braces for addr6 initializer Date: Tue, 13 Nov 2018 10:02:28 +0100 Message-ID: <20181113100228.6843ac40@redhat.com> References: <20181112221248.11477-1-natechancellor@gmail.com> <20181113061146.12182-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Sabrina Dubroca , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Joe Perches To: Nathan Chancellor Return-path: In-Reply-To: <20181113061146.12182-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Mon, 12 Nov 2018 23:11:47 -0700 Nathan Chancellor wrote: > Clang warns: > > drivers/net/geneve.c:428:29: error: suggest braces around initialization > of subobject [-Werror,-Wmissing-braces] > struct in6_addr addr6 = { 0 }; > ^ > {} > > Most initializations of structs in the kernel seem to use this format. > > Fixes: a07966447f39 ("geneve: ICMP error lookup handler") > Suggested-by: Joe Perches > Signed-off-by: Nathan Chancellor Also, Reviewed-by: Stefano Brivio -- Stefano