From: Stefano Brivio <sbrivio@redhat.com>
To: vladbu@mellanox.com
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, ast@kernel.org,
daniel@iogearbox.net
Subject: Re: [PATCH net-next 02/17] net: sched: protect block state with spinlock
Date: Tue, 13 Nov 2018 11:07:12 +0100 [thread overview]
Message-ID: <20181113110712.4462807a@redhat.com> (raw)
In-Reply-To: <20181112.092859.498970939054805019.davem@davemloft.net>
Vlad,
On Mon, 12 Nov 2018 09:28:59 -0800 (PST)
David Miller <davem@davemloft.net> wrote:
> From: Vlad Buslov <vladbu@mellanox.com>
> Date: Mon, 12 Nov 2018 09:55:31 +0200
>
> > +#define ASSERT_BLOCK_LOCKED(block) \
> > + WARN_ONCE(!spin_is_locked(&(block)->lock), \
> > + "BLOCK: assertion failed at %s (%d)\n", __FILE__, __LINE__)
>
> spin_is_locked() is not usable for assertions.
See also b86077207d0c ("igbvf: Replace spin_is_locked() with lockdep").
--
Stefano
next prev parent reply other threads:[~2018-11-13 20:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 7:55 [PATCH net-next 00/17] Refactor classifier API to work with chain/classifiers without rtnl lock Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue Vlad Buslov
2018-11-12 17:28 ` David Miller
2018-11-13 13:13 ` Vlad Buslov
2018-11-13 16:08 ` David Miller
2018-11-12 7:55 ` [PATCH net-next 02/17] net: sched: protect block state with spinlock Vlad Buslov
2018-11-12 17:28 ` David Miller
2018-11-13 10:07 ` Stefano Brivio [this message]
2018-11-13 13:28 ` Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 03/17] net: sched: refactor tc_ctl_chain() to use block->lock Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 04/17] net: sched: protect block->chain0 with block->lock Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 05/17] net: sched: traverse chains in block with tcf_get_next_chain() Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 06/17] net: sched: protect chain template accesses with block lock Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 07/17] net: sched: lock the chain when accessing filter_chain list Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 08/17] net: sched: introduce reference counting for tcf proto Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 09/17] net: sched: traverse classifiers in chain with tcf_get_next_proto() Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 10/17] net: sched: refactor tp insert/delete for concurrent execution Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 11/17] net: sched: prevent insertion of new classifiers during chain flush Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 12/17] net: sched: track rtnl lock status when validating extensions Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 13/17] net: sched: extend proto ops with 'put' callback Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 14/17] net: sched: extend proto ops to support unlocked classifiers Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 15/17] net: sched: add flags to Qdisc class ops struct Vlad Buslov
2018-11-12 7:55 ` [PATCH net-next 16/17] net: sched: conditionally take rtnl lock on rules update path Vlad Buslov
2018-11-13 9:40 ` Stefano Brivio
2018-11-13 13:25 ` Vlad Buslov
2018-11-13 13:40 ` Stefano Brivio
2018-11-13 13:58 ` Vlad Buslov
2018-11-13 15:53 ` Stefano Brivio
2018-11-13 16:57 ` Stefano Brivio
2018-11-12 7:55 ` [PATCH net-next 17/17] net: sched: unlock rules update API Vlad Buslov
2018-11-12 17:30 ` David Miller
2018-11-13 13:46 ` Vlad Buslov
2018-11-14 6:44 ` Jiri Pirko
2018-11-14 16:45 ` Vlad Buslov
2018-11-15 10:20 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113110712.4462807a@redhat.com \
--to=sbrivio@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).