From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH net-next 02/17] net: sched: protect block state with
 spinlock
Date: Tue, 13 Nov 2018 11:07:12 +0100
Message-ID: <20181113110712.4462807a@redhat.com>
References: <1542009346-23780-1-git-send-email-vladbu@mellanox.com>
        <1542009346-23780-3-git-send-email-vladbu@mellanox.com>
        <20181112.092859.498970939054805019.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
        ast@kernel.org, daniel@iogearbox.net
To: vladbu@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:58910 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731448AbeKMUEk (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 13 Nov 2018 15:04:40 -0500
In-Reply-To: <20181112.092859.498970939054805019.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Vlad,

On Mon, 12 Nov 2018 09:28:59 -0800 (PST)
David Miller <davem@davemloft.net> wrote:

> From: Vlad Buslov <vladbu@mellanox.com>
> Date: Mon, 12 Nov 2018 09:55:31 +0200
> 
> > +#define ASSERT_BLOCK_LOCKED(block)					\
> > +	WARN_ONCE(!spin_is_locked(&(block)->lock),		\
> > +		  "BLOCK: assertion failed at %s (%d)\n", __FILE__,  __LINE__)  
> 
> spin_is_locked() is not usable for assertions.

See also b86077207d0c ("igbvf: Replace spin_is_locked() with lockdep").

-- 
Stefano