From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH] ip-address: Fix filtering by negated address flags
Date: Tue, 13 Nov 2018 14:47:59 -0800 [thread overview]
Message-ID: <20181113144759.26a4d403@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20181113151201.19297-1-phil@nwl.cc>
On Tue, 13 Nov 2018 16:12:01 +0100
Phil Sutter <phil@nwl.cc> wrote:
> + if (arg[0] == '-') {
> + inv = true;
> + arg++;
> + }
The inverse logic needs to be moved into the loop handling filter names.
Otherwise, you get weirdness like "-dynamic" being accepted and not
doing what was expected.
Also, please make sure the man page matches the code.
next prev parent reply other threads:[~2018-11-14 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 15:12 [iproute PATCH] ip-address: Fix filtering by negated address flags Phil Sutter
2018-11-13 22:47 ` Stephen Hemminger [this message]
2018-11-14 10:52 ` Phil Sutter
2018-11-14 19:29 ` Stephen Hemminger
2018-11-15 11:13 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113144759.26a4d403@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox