From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Brivio Subject: Re: [PATCH net-next 16/17] net: sched: conditionally take rtnl lock on rules update path Date: Tue, 13 Nov 2018 17:57:22 +0100 Message-ID: <20181113175722.25868f93@redhat.com> References: <1542009346-23780-1-git-send-email-vladbu@mellanox.com> <1542009346-23780-17-git-send-email-vladbu@mellanox.com> <20181113104016.76d12436@redhat.com> <20181113144035.03e3e278@redhat.com> <20181113165307.45987362@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , "jhs@mojatatu.com" , "xiyou.wangcong@gmail.com" , "jiri@resnulli.us" , "davem@davemloft.net" , "ast@kernel.org" , "daniel@iogearbox.net" To: Vlad Buslov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:48054 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730732AbeKNC4Z (ORCPT ); Tue, 13 Nov 2018 21:56:25 -0500 In-Reply-To: <20181113165307.45987362@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 13 Nov 2018 16:53:07 +0100 Stefano Brivio wrote: > But to make that effective, you would need to protect the read too, and > that makes your optimisation not really overzealous I think. > > I'd rather go with an additional comment, if that doesn't become > unreadable. Oh, and of course, this whole thing makes sense only if for some reason you end up keeping this function. Maybe ignore my comments on this patch at least for the moment being ;) -- Stefano